Skip to content

GetResponse*Events stop after a response was set #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wouterj opened this issue Nov 24, 2014 · 1 comment
Closed

GetResponse*Events stop after a response was set #4516

wouterj opened this issue Nov 24, 2014 · 1 comment
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.

Comments

@wouterj
Copy link
Member

wouterj commented Nov 24, 2014

For instance, kernel.view stops executing the other listeners once a listener has set a response. This is currently not noted in the documentation. This caused some misunderstanding on IRC.
@wouterj wouterj added Missing Documentation good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. labels Nov 24, 2014
@Lumbendil
Copy link
Contributor

I'm working on this.

@Lumbendil Lumbendil mentioned this issue Nov 29, 2014
Merged
@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label Dec 17, 2014
weaverryan added a commit that referenced this issue Dec 20, 2014
@weaverryan
feature #4532 GetResponse*Events stop after a response was set (Lumbe…
f591e6e 
…ndil)

This PR was merged into the 2.3 branch.

Discussion
----------

GetResponse*Events stop after a response was set

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | All versions
| Fixed tickets | #4516

The kernel.view and kernel.exception events stop propagation when a response is set, and it wasn't noted on the documentation.

Commits
-------

bebce0e Fix incorrect event name.
e729750 Changed phrasing to explain the effects off propagation stopping.
d13943a Add missing info about kernel.request event.
25e1069 Added notes specifying the propagation behaviour for kernel.view and kernel.exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weaverryan @Lumbendil @wouterj