Skip to content

Cleanup required in References section -> Dependancy Injection article #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
keymaster opened this issue Jun 28, 2011 · 1 comment
Closed

Cleanup required in References section -> Dependancy Injection article #470

keymaster opened this issue Jun 28, 2011 · 1 comment

Comments

@keymaster
Copy link

  1. Missing example for "data_collector" tag.
  2. Missing example for "templating.renderer" tag.
  3. Should list "templating.engine" tag in the list.
  4. Should list "monolog.logger" tag in the list.
weaverryan added a commit that referenced this issue Apr 28, 2012
@weaverryan
[reference][doc_tags] Totally overhauling the DIC tags reference sect…
c47406b 
…ion - see #470
weaverryan added a commit that referenced this issue Apr 28, 2012
@weaverryan
[reference][dic_tags] Adding all missing core tags to the DIC tags re…
c45eb94 
…ference - see #470
@weaverryan
Copy link
Member

I've just refactored this entire article, fixed things up, added examples, and added the following tags which were missing:

  • validator.constraint_validator
  • security.voter
  • security.remember_me_aware
  • security.listener.factory
  • swiftmailer.plugin

There are several changes that are needed for 2.1, which I've highlighted in #1320.

So, I think we can finally close this issue :). There may be individual tags that could use more detail and would be more appropriate in their own cookbook article, but we'll leave that for the future.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weaverryan @keymaster