Skip to content

Serializer doc issues #7282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Dec 21, 2016 · 5 comments
Closed

Serializer doc issues #7282

javiereguiluz opened this issue Dec 21, 2016 · 5 comments
Labels
bug good first issue Ideal for your first contribution! (some Symfony experience may be required) Serializer
Milestone
3.1

Comments

@javiereguiluz
Copy link
Member

Reported by @magarzon in the #support channel of Symfony's Slack:

Is there a way to disable the cache for the serializer? I'm having problems with the cached metadata, I've tried to set cache: false in framework config, but it's not working

Weird thing is that there is a service defined serializer.mapping.cache.symfony that is a "memory cache", but that doesn't works with the serializer, it complains that doesn't implements Doctrine\Common\Cache\Cache interface. Probably an issue?

because it has the "same" name as the recommended cache in the documentation, serializer.mapping.cache.apc

Probably it's my code, I'm going to check

No, it's not my code, it's documentation not up-to-date and probably bad naming: serializer.mapping.cache.apc is deprecated since 3.1, but is still recommended in this doc without any warning: https://symfony.com/doc/current/serializer.html#enabling-the-metadata-cache
@xabbuh xabbuh added this to the 3.1 milestone Dec 21, 2016
@javiereguiluz javiereguiluz added bug good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Apr 24, 2017
@javiereguiluz
Copy link
Member Author

Can anyone with experience using Serializer please verify this bug report? Thanks!

@xabbuh
Copy link
Member

xabbuh commented Apr 25, 2017

The serializer.mapping.cache.apc service is indeed deprecated since symfony/symfony#18567 (merged into the 3.1 branch).

@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jul 7, 2017
@javiereguiluz javiereguiluz mentioned this issue Jul 7, 2017
Closed
@javiereguiluz javiereguiluz removed the hasPR A Pull Request has already been submitted for this issue. label Dec 23, 2017
@javiereguiluz
Copy link
Member Author

If someone understands the Serializer component well, please continue my failed pull request to fix this: https://github.com/symfony/symfony-docs/pull/8133/files Thanks!

@javiereguiluz
Copy link
Member Author

@xabbuh in my failed PR (#8133) you made some useful comments about how to fix this. Do you think you could finish this issue yourself? It's the last one pending in the ancient Symfony 3.1 milestone, so it'd be great to finish it. Thank you!

@xabbuh xabbuh mentioned this issue Jul 10, 2018
Merged
@xabbuh
Copy link
Member

xabbuh commented Jul 10, 2018

see #10039

javiereguiluz added a commit that referenced this issue Jul 11, 2018
@javiereguiluz
minor #10039 update the serializer cache description (xabbuh)
556329c 
This PR was merged into the 3.4 branch.

Discussion
----------

update the serializer cache description

This fixes #7282.

Commits
-------

b65d15a update the serializer cache description
@xabbuh xabbuh closed this as completed Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Ideal for your first contribution! (some Symfony experience may be required) Serializer
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
4 participants
@javiereguiluz @xabbuh @HeahDude @carsonbot