Skip to content

[DI] Deprecate dumping an uncompiled container #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue Dec 23, 2016 · 1 comment
Closed

[DI] Deprecate dumping an uncompiled container #7289

javiereguiluz opened this issue Dec 23, 2016 · 1 comment

Comments

@javiereguiluz
Copy link
Member

See symfony/symfony#20634

@javiereguiluz
Copy link
Member Author

Closing it as "won't fix" because we only mention PhpDumper in this article -> https://symfony.com/doc/current/components/dependency_injection/compilation.html and all the examples compile the container before dumping it. So we've always promoted the best practice here and there's no need to explain this detail (and by the way, the developer will get a nice and easy to understand error message in case they don't compile the container).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant