Skip to content

Document the new short Yaml syntax for service definition #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Feb 1, 2017 · 5 comments
Closed

Document the new short Yaml syntax for service definition #7441

javiereguiluz opened this issue Feb 1, 2017 · 5 comments
Labels
DependencyInjection hasPR A Pull Request has already been submitted for this issue.
Milestone
3.3

Comments

@javiereguiluz
Copy link
Member

Added in symfony/symfony#21313

Before:

services:
    App\Foo\Bar: 
        arguments: ['@baz', 'foo', '%qux%']

After:

services:
    App\Foo\Bar: ['@baz', 'foo', '%qux%']
@javiereguiluz javiereguiluz added this to the 3.3 milestone Feb 1, 2017
@weaverryan weaverryan mentioned this issue Apr 15, 2017
Merged
@TomasVotruba
Copy link

Just curious, what is the shortest possible registration?

Sth like this?

services:
    App\Foo\Bar: []

@theofidry
Copy link
Contributor

theofidry commented Apr 28, 2017 •
edited
Loading 

services:
    App\Foo\Bar: {}

not sure if the following would work:

services:
    App\Foo\Bar: ~

@TomasVotruba
Copy link

TomasVotruba commented Apr 28, 2017 •
edited
Loading

Thanks, will try.

Works like a charm!

services:
    App\Foo\Bar: ~

Just YAML service autocomplete and it will be flawless 👍

@GuilhemN GuilhemN mentioned this issue Apr 30, 2017
Closed
@GuilhemN
Copy link
Contributor

see #7860

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Apr 30, 2017
@xabbuh xabbuh closed this as completed in dc9ac9b May 4, 2017
weaverryan added a commit that referenced this issue May 5, 2017
@weaverryan
feature #7807 Updates to DI config for 3.3 (weaverryan, GuilhemN)
cbedd79 
This PR was merged into the master branch.

Discussion
----------

Updates to DI config for 3.3

Hi guys!

WIP changes the new DI changes in 3.3! Woohoo! Some notes for myself:

This relates to, oh, just these 10+ issues :). Assume they will all be closed by this one PR - before merge, if any of them aren't covered, I'll remove them.

TODOS later (some might already be done)
- update to use `debug:container --types` (symfony/symfony#22624)
- update all other documents for possible changes for autowiring and autoconfigure
- new page for existing Symfony users to explain the changes
- update autowire section to talk about using aliases
- document instanceof and also the ability to add configuration to the PSR4 loader
- some links in the controller go to the API docs of `Controller`. But this is wrong, the methods
now live in `ControllerTrait`... but the API docs for traits is basically broken: http://api.symfony.com/master/Symfony/Bundle/FrameworkBundle/Controller/ControllerTrait.html
- how should we pass a parameter to a controller?
- do Twig extensions still need to be public? If so, the example in `service_container` about autoconfigure is still not quite right

Definitely included in this PR
* #7544
* #7482
* #7339
* #7672

Not included in this PR (but related to DI changes)
* #7329
* #7782
* #7777
* #7706
* #7608
* #7538
* #7441
* #7255
* ~~#7041~~
* ~~#7445~~
* ~~#7444~~
* ~~#7436~~

Commits
-------

22adfbd removing duplicate target
12c4944 Tweaks after amazing review from @GuilhemN and @xabbuh
cac3c6c Merge remote-tracking branch 'origin/master' into di-3.3-changes
2229fd3 Merge remote-tracking branch 'origin/master' into di-3.3-changes
5452c61 Adding section about public: false
ee27765 Adding versionadded
bc7088d Merge remote-tracking branch 'origin/di-3.3-changes' into di-3.3-changes
443aec2 Merge pull request #7857 from GuilhemN/patch-1
89e12de bad link
6de83e2 fixing build problem
759e9b2 last tweaks from feedback
45500b3 Adding details and usages of fetching the service as a controller arg
70178d1 adding note about autoconfigure
6e6ed94 more tweaks
0e48bd8 [WIP] Updates to DI config for 3.3
9ab27f0 Add xml files
2636bea bad link
c45daf4 fixing build problem
9e84572 last tweaks from feedback
049df7d Adding details and usages of fetching the service as a controller arg
105801c adding note about autoconfigure
2d11347 more tweaks
8433fc1 [WIP] Updates to DI config for 3.3
@apfelbox
Copy link
Contributor

apfelbox commented Aug 6, 2018

@weaverryan not sure, but was there something added about this issue somewhere in the docs?
Because the linked PR #7807 explicitly added this issue to "Not included in this PR (but related to DI changes)"

@HeahDude HeahDude mentioned this issue Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DependencyInjection hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
6 participants
@javiereguiluz @TomasVotruba @apfelbox @xabbuh @theofidry @GuilhemN