Skip to content

Added new fluent PHP config formats for services and routes #8462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Oct 3, 2017 · 5 comments
Closed

Added new fluent PHP config formats for services and routes #8462

javiereguiluz opened this issue Oct 3, 2017 · 5 comments
Labels
DependencyInjection DX Routing
Milestone
4.2

Comments

@javiereguiluz
Copy link
Member

We must make a decision about this:

  1. Publish a new article mentioning this new notation ...
  2. ... or adding this new format to EVERY example of the docs (this would be a huge task!)
@javiereguiluz javiereguiluz added this to the 3.4 milestone Oct 3, 2017
@afurculita
Copy link
Contributor

+1 for adding this new format to EVERY example of the docs

@HeahDude HeahDude added the DX label Mar 4, 2019
@HeahDude HeahDude mentioned this issue Mar 5, 2019
Closed
@HeahDude
Copy link
Contributor

HeahDude commented Mar 5, 2019

This feels needed somehow https://github.com/symfony/symfony-docs/pull/11085/files#diff-7b2545dd61a3817c08117d17725de110L63.

@HeahDude HeahDude modified the milestones: 3.4, 4.2 Mar 5, 2019
javiereguiluz added a commit that referenced this issue Mar 5, 2019
@javiereguiluz
minor #11085 Fixed route examples (Jules Pietri)
7cd23ce 
This PR was squashed before being merged into the 4.2 branch (closes #11085).

Discussion
----------

Fixed route examples

Fixes partially #8462 and #10762.

Commits
-------

21408cf Fixed route examples
@afilina
Copy link
Contributor

afilina commented Jul 2, 2019

@javiereguiluz @HeahDude Do you guys need help on that?

@xabbuh
Copy link
Member

xabbuh commented Jul 4, 2019

#10824 does the DI part

@HeahDude
Copy link
Contributor

And #11085 did the routing part. Closing here, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DependencyInjection DX Routing
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
5 participants
@javiereguiluz @afilina @xabbuh @afurculita @HeahDude