Skip to content

[Cache] Superfluous import of PhpFilesAdapter in Php Array Cache Adapter Documentation #8672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stollr opened this issue Nov 15, 2017 · 0 comments
Closed

[Cache] Superfluous import of PhpFilesAdapter in Php Array Cache Adapter Documentation #8672

stollr opened this issue Nov 15, 2017 · 0 comments
Labels
bug Cache hasPR A Pull Request has already been submitted for this issue. Status: Needs Review
Milestone
3.3

Comments

@stollr
Copy link

stollr commented Nov 15, 2017

In the first code example in the Php Array Cache Adapter documentation there is this line:

use Symfony\Component\Cache\Adapter\PhpFilesAdapter;

But this class is never used. Instead an object of class FilesystemAdapter (which is not imported) is instantiated

// a backup adapter, if you set values after warmup
new FilesystemAdapter()

I guess that something is mixed up there. Can somebody look into it?
@xabbuh xabbuh added this to the 3.3 milestone Nov 16, 2017
@javiereguiluz javiereguiluz mentioned this issue Jan 25, 2018
Merged
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Cache hasPR A Pull Request has already been submitted for this issue. Status: Needs Review
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
4 participants
@javiereguiluz @stollr @xabbuh @carsonbot