Skip to content

Fix validation YAML paths #8727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weaverryan opened this issue Nov 21, 2017 · 3 comments
Closed

Fix validation YAML paths #8727

weaverryan opened this issue Nov 21, 2017 · 3 comments
Milestone
4.0

Comments

@weaverryan
Copy link
Member

In #8593, one of the automated changes changed the validation.yml paths like this:

- src/AppBundle/Resources/config/validation.yml
+ src/Resources/config/validation.yml

But, that's not correct, right? Is there a correct path for the validation YAML files? Or does the user need to add a framework.validation.mapping.paths config? I believe this is the case.

@yceruto could you update the paths? If I'm correct about needing the config, then I guess the path should be config/validation.yaml, and we will need a note near the top that mentions the config that's needed (probably can just link to the reference section). I don't want to make a huge thing out of this, as it's not the recommended config, but it should be accurate and mentioned.

Thanks!
@weaverryan weaverryan added this to the 4.0 milestone Nov 21, 2017
@yceruto
Copy link
Member

yceruto commented Nov 21, 2017 •
edited
Loading

Yeah, it was merged before symfony/symfony#24856 :) so it needs to be updated again, same for symfony/symfony#24833 and config/serializer.yaml.

@weaverryan
Copy link
Member Author

@yceruto how are things now in the 4.0 branch. Do we need more changes? Or can this be closed? Thx :)

@yceruto yceruto mentioned this issue Nov 29, 2017
Merged
@yceruto
Copy link
Member

yceruto commented Nov 29, 2017

See #8782 ;)

xabbuh added a commit that referenced this issue Nov 30, 2017
@xabbuh
minor #8782 Update the validations path to Symfony 4 (yceruto)
0d2e368 
This PR was merged into the 4.0 branch.

Discussion
----------

Update the validations path to Symfony 4

Fix #8727

Commits
-------

d65ac5c Update validation path
@xabbuh xabbuh closed this as completed Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@weaverryan @xabbuh @yceruto