Skip to content

Codes examples colors #9524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Krazitchek opened this issue Mar 30, 2018 · 5 comments
Closed

Codes examples colors #9524

Krazitchek opened this issue Mar 30, 2018 · 5 comments
Assignees
Labels

Comments

@Krazitchek
Copy link

Why changing what was good ?... new theme for codes samples rendering in documentation is less readable than "before" because of some dark font colors (dark blue) on black background...

@javiereguiluz
Copy link
Member

We haven't made any recent change about that (at least on purpose!). Could you please share a screenshot of the problematic code listings? Thanks!

@Krazitchek
Copy link
Author

Krazitchek commented Mar 30, 2018

In commit 8c84bb1 we read that JS and CSS was added.

What i did:

  • Download last 2.7 documentation archive from github
  • Build (make html) documentation with python-sphinx using fabpot/sphinx-php.git
  • Copy assets directory in generated html directory to get css and js
  • Launch index.html

In browser console i see this error: TypeError: $.getQueryParameters is not a function

Screenshot before:
sf-before

Same screenshot now:
sf-now

@javiereguiluz
Copy link
Member

I honestly don't understand what's going on here. I literally took the same CSS and JS files used on symfony.com and added to the repo. Could you please use the browser's inspector on the code which shows a wrong highlight and see if it's because of some missing style or some missing CSS, etc. Thanks!

@javiereguiluz javiereguiluz self-assigned this Apr 3, 2018
@Krazitchek
Copy link
Author

Maybe i do the wrongs things to get the documentation for offline reading (no internet at work, yes, it's possible in 2018 !).
It will be intersting to know if i'm the only one to experiment this case.
All i can see in browser console is this error: TypeError: $.getQueryParameters is not a function.

@javiereguiluz
Copy link
Member

@Krazitchek in #9972 we've switched the default theme used to build docs locally. Now it doesn't look like symfony.com at all ... but at least everything works and the generated docs are fully usable. That's why I'm closing this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants