-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Codes examples colors #9524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We haven't made any recent change about that (at least on purpose!). Could you please share a screenshot of the problematic code listings? Thanks! |
In commit 8c84bb1 we read that JS and CSS was added. What i did:
In browser console i see this error: TypeError: $.getQueryParameters is not a function |
I honestly don't understand what's going on here. I literally took the same CSS and JS files used on symfony.com and added to the repo. Could you please use the browser's inspector on the code which shows a wrong highlight and see if it's because of some missing style or some missing CSS, etc. Thanks! |
Maybe i do the wrongs things to get the documentation for offline reading (no internet at work, yes, it's possible in 2018 !). |
@Krazitchek in #9972 we've switched the default theme used to build docs locally. Now it doesn't look like symfony.com at all ... but at least everything works and the generated docs are fully usable. That's why I'm closing this issue. Thanks! |
Why changing what was good ?... new theme for codes samples rendering in documentation is less readable than "before" because of some dark font colors (dark blue) on black background...
The text was updated successfully, but these errors were encountered: