Document the use of ignored_attributes context option #11088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alanpoulain just asking because I don't know this component well: does this pull request fully document the changes made in symfony/symfony#28709? Thanks. |
|
I don't know. But at least it documents this missing thing. |
dunglas
approved these changes
Mar 6, 2019
|
@javiereguiluz no, there is the new default context to document, but it's not very useful while symfony/symfony#28927 isn't finished/merged. I'll take care of documenting this feature (and the other one I introduced recently). |
|
Actually, we should merge #11067 instead of this one. |
|
As suggested, we're closing this in favor of #11067, which was just merged. @alanpoulain I'm sorry this time your contribution wasn't merged ... but we're looking forward to receive more contributions from you in the future. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documentation was missing since this PR was merged for 4.2: symfony/symfony#28709