-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Adds documentation for monolog processors. #11328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Apr 6, 2019
logging/processors.rst
Outdated
* :class:`Symfony\\Bridge\\Monolog\\Processor\\WebProcessor` overrides data from the request using the data inside Symfony's request object. | ||
|
||
.. versionadded:: 3.4 | ||
The :class:``Symfony\\Bridge\\Monolog\\Processor\\TokenProcessor`` class was added in Symfony 3.4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one tick should be use for the class
Adds both a short description for existing processors as well as a note for the newly added TokenProcessor added in 3.4. Replaces #8156
OskarStark
approved these changes
Apr 6, 2019
@@ -160,6 +160,16 @@ If you use several handlers, you can also register a processor at the | |||
handler level or at the channel level instead of registering it globally | |||
(see the following sections). | |||
|
|||
Symfony's MonologBridge provides processors that can be registered inside your application. | |||
|
|||
* :class:`Symfony\\Bridge\\Monolog\\Processor\\DebugProcessor` adds additional information useful for debugging like a timestamp or an error message to the record. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for mergers ... please wrap these lines to make them 80-char long. Thanks.
javiereguiluz
approved these changes
Apr 7, 2019
wouterj
added a commit
that referenced
this pull request
Apr 7, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Adds documentation for monolog processors. Adds both a short description for existing processors as well as a note for the newly added TokenProcessor added in 3.4. I tried not to interfere with #10244 as this introduces documentation for more processors added in 4.3, so that PR hopefully can build on this one. Replaces #8156 EUFOSSA Commits ------- 67f8c2c Adds documentation for monolog processors.
wouterj
added a commit
that referenced
this pull request
Apr 7, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⭐️ EU-FOSSA Hackathon
https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming
Status: Reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds both a short description for existing processors as well as a note for the newly added TokenProcessor added in 3.4. I tried not to interfere with #10244 as this introduces documentation for more processors added in 4.3, so that PR hopefully can build on this one.
Replaces #8156
EUFOSSA