From 315103ff805da0ccc5c86ebeb4a2ddea17f26dc0 Mon Sep 17 00:00:00 2001
From: Peter Bowyer <peter@mapledesign.co.uk>
Date: Fri, 19 Jul 2019 09:01:53 +0100
Subject: [PATCH] When overriding `session` service definition, make it public

`Symfony\Bundle\FrameworkBundle\Controller\ControllerTrait::addFlash()` relies on getting the `session` service from the service container.

Since 3.4 services defined in `services.yaml` are private by default. When overriding the `session`  service definition, it has to be explicitly marked as public.
---
 session.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/session.rst b/session.rst
index 506229ed387..53cf435eb15 100644
--- a/session.rst
+++ b/session.rst
@@ -180,6 +180,7 @@ the default ``AttributeBag`` by the ``NamespacedAttributeBag``:
 
         # config/services.yaml
         session:
+            public: true
             class: Symfony\Component\HttpFoundation\Session\Session
             arguments: ['@session.storage', '@session.namespacedattributebag', '@session.flash_bag']