Added Unicode information about routes #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I could tell, the unicode support was added already by other changes in the routing component and the original PR in symfony/symfony#3629 is now updated just to include those tests. Imho this could be merged regardless of the original PR but imho it would be nice to also have that merged as well... Kind regards. |
weaverryan
added a commit
that referenced
this pull request
Apr 21, 2012
Added Unicode information about routes
weaverryan
added a commit
that referenced
this pull request
Apr 21, 2012
|
I've merged in the PR as it appears that unicode is supported now even without your PR. But if I'm mistaken, please let me know! Thanks! |
|
@weaverryan It seems I was a bit wrong about the Unicode support. While Symfony2.1 will bring some unicode support it will not be full support. So maybe we should revert this someone. Should I submit a PR to correct this? Kind regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When/if symfony/symfony#3629 will be merged then this should be merged as well as it documents the change.
Thanks.