HTTP Foundation edits #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,7 +145,7 @@ Symfony is architected to match this reality. | |||
| Requests and Responses in Symfony | |||
| --------------------------------- | |||
|
|
|||
| PHP comes packaged with an array variables and methods that allow the developer | |||
| PHP comes packaged with array variables and methods that allow the developer | |||
There was a problem hiding this comment.
I've kept this one with the old syntax - there should be an indefinite article here.
|
I left some comments, but I really appreciate the help with how things "sound" (as well as catching some of my mistakes). Thanks! |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Dec 11, 2012
This PR was squashed before being merged into the master branch (closes #6014). Commits ------- 2b13760 [Filesystem] [mirror] added "delete" option Discussion ---------- [Filesystem] [mirror] added "delete" option Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: Todo: - License of the code: MIT Documentation PR: symfony/symfony-docs#123 I added a "delete" option to the mirror function. If set to true, then files present in target dir and not in origin dir will be removed. Added also unit test for these feature. --------------------------------------------------------------------------- by pborreli at 2012-11-16T00:58:19Z Symfony2 code standard use lowercase `true` and `false` --------------------------------------------------------------------------- by mylen at 2012-11-16T20:25:19Z I have problem to believe that the last commit (merging two if together) was to blame for the segfault on travis... when I run the unit testing on my machine, I get: I'm using PHP 5.4.7 by the way... Time: 2 seconds, Memory: 3.25Mb OK, but incomplete or skipped tests! Tests: 80, Assertions: 106, Skipped: 14. --------------------------------------------------------------------------- by pborreli at 2012-11-16T20:38:40Z Can you fix end-of-lines ? --------------------------------------------------------------------------- by mylen at 2012-11-16T20:52:37Z I put UNIX line feed and UTF8 charset --------------------------------------------------------------------------- by mylen at 2012-11-16T20:53:59Z Sorry, I add to clone the symfony repo with github and did small editing using pspad, I forgot to setup charset and line feed...
fabpot
added a commit
to symfony/filesystem
that referenced
this pull request
Dec 11, 2012
This PR was squashed before being merged into the master branch (closes #6014). Commits ------- 2b13760 [Filesystem] [mirror] added "delete" option Discussion ---------- [Filesystem] [mirror] added "delete" option Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: Todo: - License of the code: MIT Documentation PR: symfony/symfony-docs#123 I added a "delete" option to the mirror function. If set to true, then files present in target dir and not in origin dir will be removed. Added also unit test for these feature. --------------------------------------------------------------------------- by pborreli at 2012-11-16T00:58:19Z Symfony2 code standard use lowercase `true` and `false` --------------------------------------------------------------------------- by mylen at 2012-11-16T20:25:19Z I have problem to believe that the last commit (merging two if together) was to blame for the segfault on travis... when I run the unit testing on my machine, I get: I'm using PHP 5.4.7 by the way... Time: 2 seconds, Memory: 3.25Mb OK, but incomplete or skipped tests! Tests: 80, Assertions: 106, Skipped: 14. --------------------------------------------------------------------------- by pborreli at 2012-11-16T20:38:40Z Can you fix end-of-lines ? --------------------------------------------------------------------------- by mylen at 2012-11-16T20:52:37Z I put UNIX line feed and UTF8 charset --------------------------------------------------------------------------- by mylen at 2012-11-16T20:53:59Z Sorry, I add to clone the symfony repo with github and did small editing using pspad, I forgot to setup charset and line feed...
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Feb 19, 2013
This PR was merged into the 2.0 branch. Commits ------- cb03074 [DomCrawler] lowered parsed protocol string (fixes #6986) Discussion ---------- [DomCrawler] lowered parsed protocol string (fixes #6986) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6986 | License | MIT | Doc PR | symfony/symfony-docs#123 Are UTs needed for this?
fabpot
added a commit
to symfony/filesystem
that referenced
this pull request
May 16, 2013
This PR was squashed before being merged into the master branch (closes #6014). Commits ------- 2b13760 [Filesystem] [mirror] added "delete" option Discussion ---------- [Filesystem] [mirror] added "delete" option Bug fix: no Feature addition: yes Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: Todo: - License of the code: MIT Documentation PR: symfony/symfony-docs#123 I added a "delete" option to the mirror function. If set to true, then files present in target dir and not in origin dir will be removed. Added also unit test for these feature. --------------------------------------------------------------------------- by pborreli at 2012-11-16T00:58:19Z Symfony2 code standard use lowercase `true` and `false` --------------------------------------------------------------------------- by mylen at 2012-11-16T20:25:19Z I have problem to believe that the last commit (merging two if together) was to blame for the segfault on travis... when I run the unit testing on my machine, I get: I'm using PHP 5.4.7 by the way... Time: 2 seconds, Memory: 3.25Mb OK, but incomplete or skipped tests! Tests: 80, Assertions: 106, Skipped: 14. --------------------------------------------------------------------------- by pborreli at 2012-11-16T20:38:40Z Can you fix end-of-lines ? --------------------------------------------------------------------------- by mylen at 2012-11-16T20:52:37Z I put UNIX line feed and UTF8 charset --------------------------------------------------------------------------- by mylen at 2012-11-16T20:53:59Z Sorry, I add to clone the symfony repo with github and did small editing using pspad, I forgot to setup charset and line feed...
4 tasks
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Feb 1, 2016
…ereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- [2.3] Fixed an undefined variable in Glob::toRegex | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#123 Note: to be merged **only in Symfony 2.3**. `$delimiter` variable exists in the rest of Symfony versions. Commits ------- f0b7c14 [2.3] Fixed an undefined variable in Glob::toRegex
joshtrichards
pushed a commit
to joshtrichards/symfony-finder
that referenced
this pull request
Apr 26, 2024
…ereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- [2.3] Fixed an undefined variable in Glob::toRegex | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#123 Note: to be merged **only in Symfony 2.3**. `$delimiter` variable exists in the rest of Symfony versions. Commits ------- 68b0200 [2.3] Fixed an undefined variable in Glob::toRegex
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some code syntax mistakes and first pass at editing for grammar and readability