[minor] remove usage of Kernel::$rootDir from docs #12719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was submitted for the 5.0 branch but it was merged into the 4.3 branch instead (closes symfony#12707). Discussion ---------- uppercase Commits ------- 6ba282e uppercase
…(jzawadzki) This PR was submitted for the 5.0 branch but it was merged into the 4.3 branch instead (closes symfony#12720). Discussion ---------- Changed names of Intl classes in form types docs As per symfony/symfony#28846 we changed Intl classes to be more specific. Looks like some docs left with old naming. Commits ------- f5f64e1 Changed names of Intl classes in form types docs
wouterj
approved these changes
Nov 29, 2019
* upstream/4.3: Changed names of Intl classes in form types docs uppercase
51cfb0e to
9da96e1
Compare
|
Thanks! (merged in 4.3) |
javiereguiluz
added a commit
that referenced
this pull request
Nov 30, 2019
…adzki) This PR was submitted for the 5.0 branch but it was squashed and merged into the 4.3 branch instead (closes #12719). Discussion ---------- [minor] remove usage of Kernel::$rootDir from docs As per symfony/symfony#28810 $rootDir has been removed in 5.0 - use getProjectDir in docs instead - small change to be consistent Commits ------- 9da96e1 [minor] remove usage of Kernel::$rootDir from docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per symfony/symfony#28810 $rootDir has been removed in 5.0 - use getProjectDir in docs instead - small change to be consistent