Skip to content

[DomCrawler] Document UriResolver #13054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2020
Merged

[DomCrawler] Document UriResolver #13054

merged 1 commit into from
Feb 11, 2020

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Feb 5, 2020

fixes #13040

@OskarStark OskarStark added this to the 5.1 milestone Feb 5, 2020
OskarStark
OskarStark requested changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Greg, can you please add a sentence when and why could this be useful?

@lyrixx

This comment has been minimized.

Sign in to view
@lyrixx lyrixx mentioned this pull request Feb 10, 2020
Merged
@lyrixx lyrixx changed the title [DomCrawler] Document UriExpander [DomCrawler] Document UriResolver Feb 10, 2020
fabpot added a commit to symfony/symfony that referenced this pull request Feb 11, 2020
@fabpot
feature #35667 [DomCrawler] Rename UriExpander.php -> UriResolver (ly…
1b52d60 
…rixx)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[DomCrawler] Rename UriExpander.php -> UriResolver

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | refs symfony/symfony-docs#13054 (comment)
| License       | MIT
| Doc PR        | symfony/symfony-docs#13054 // don't open a new issue in doc repo

Commits
-------

3217f81 [DomCrawler] Rename UriExpander.php -> UriResolver
OskarStark
OskarStark reviewed Feb 11, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, some minor comments

@OskarStark OskarStark self-assigned this Feb 11, 2020
@OskarStark
Copy link
Contributor

OskarStark commented Feb 11, 2020 •
edited
Loading

Thank you, I made the changes while merging in 905d1fc! 🎉

@OskarStark OskarStark merged commit 4ce42c9 into symfony:master Feb 11, 2020
OskarStark added a commit that referenced this pull request Feb 11, 2020
@OskarStark
minor. refs #13054
905d1fc
@lyrixx lyrixx deleted the dom-api branch February 11, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark requested changes

@javiereguiluz javiereguiluz Awaiting requested review from javiereguiluz

Assignees

@OskarStark OskarStark

Labels
DomCrawler Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

Extracted code to expand an URI to UriExpander
4 participants
@lyrixx @OskarStark @javiereguiluz @carsonbot