Skip to content

Document routing inline requirements and defaults for host #14007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

julienfalque
Copy link
Contributor

Relates to symfony/symfony#37696.

@xabbuh xabbuh added the Waiting Code Merge Docs for features pending to be merged label Jul 30, 2020
fabpot added a commit to symfony/symfony that referenced this pull request Jul 30, 2020
…defaults for host (julienfalque)

This PR was merged into the 5.2-dev branch.

Discussion
----------

[Routing] Allow inline definition of requirements and defaults for host

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#14007

This PR extends the support of inline routing requirements and defaults to the host part, which can also contain parameters.

Commits
-------

1501476 [Routing] Allow inline definition of requirements and defaults for host
@xabbuh xabbuh removed the Waiting Code Merge Docs for features pending to be merged label Oct 16, 2020
@nicolas-grekas nicolas-grekas deleted the branch symfony:master December 7, 2020 16:34
@julienfalque
Copy link
Contributor Author

I see this was closed because of master branch removal, shall I recreate the PR onto a new branch?

@nicolas-grekas
Copy link
Member

Yes please

@julienfalque
Copy link
Contributor Author

See #14671.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants