From 4ddfa491cfdc43d7b345dead01854129cc8a6959 Mon Sep 17 00:00:00 2001 From: Thomas Landauer Date: Sat, 3 Apr 2021 18:55:31 +0200 Subject: [PATCH] Re-adding , '@session.flash_bag' It was there in 4.4: https://symfony.com/doc/4.4/session.html#basic-usage But when I omit it, I'm getting (Symfony 5.2): > Circular reference detected for service "session", path: "session -> session.flash_bag -> session". TODO: PHP config is missing for this code block. I'm doing it like this - should I make a PR? (But I don't know the XML way) ```php use function Symfony\Component\DependencyInjection\Loader\Configurator\service; use Symfony\Component\HttpFoundation\Session\Attribute\NamespacedAttributeBag; use Symfony\Component\HttpFoundation\Session\Session; $services->set('session', Session::class)->public()->args([service('session.storage'), service('session.namespacedattributebag')]); $services->set('session.namespacedattributebag', NamespacedAttributeBag::class); ``` --- session.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/session.rst b/session.rst index 2ca685e1fe4..fb9bb81cd8a 100644 --- a/session.rst +++ b/session.rst @@ -181,7 +181,7 @@ the default ``AttributeBag`` by the ``NamespacedAttributeBag``: session: public: true class: Symfony\Component\HttpFoundation\Session\Session - arguments: ['@session.storage', '@session.namespacedattributebag'] + arguments: ['@session.storage', '@session.namespacedattributebag', '@session.flash_bag'] session.namespacedattributebag: class: Symfony\Component\HttpFoundation\Session\Attribute\NamespacedAttributeBag