Skip to content

[Messenger] Document the validation middleware #16337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2022
Merged

[Messenger] Document the validation middleware #16337

merged 1 commit into from
Jan 16, 2022

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Dec 28, 2021

Close #10474

I took inspiration on the doc https://symfonycasts.com/screencast/messenger/other-middleware#validation-doctrine-transaction-etc-middleware

Reference this doc #14969 so I added next to it

@carsonbot carsonbot added this to the 5.4 milestone Dec 28, 2021
@ogizanagi
Copy link
Contributor

Thanks for opening this.
I think we could mention as well the ValidationStamp to configure validation groups. It's already mentioned in this part, but this possibility would be more discoverable next to the validation middleware samples.

@94noni
Copy link
Contributor Author

94noni commented Dec 31, 2021

Ok I’ll add a ref link here

@94noni
Copy link
Contributor Author

94noni commented Jan 3, 2022

@ogizanagi done :)

@Nek-
Copy link
Contributor

Nek- commented Jan 14, 2022

Thanks this is nice @94noni . I hope it will be merged soon!

@wouterj wouterj changed the base branch from 5.4 to 4.4 January 16, 2022 12:27
@wouterj wouterj requested a review from xabbuh as a code owner January 16, 2022 12:27
@wouterj wouterj merged commit aabb6c5 into symfony:4.4 Jan 16, 2022
@wouterj
Copy link
Member

wouterj commented Jan 16, 2022

Thank you @94noni, this is great!

As this middleware was introduced in 4.1, I've rebased your PR on 4.4 (and changed the PHP config to use the legacy format). While merging these changes up, I've added the original changes in this PR on the 5.3 branch (ref 0aea09a),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nek- Nek- Nek- approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Messenger Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Messenger] Document the validation middleware
5 participants
@94noni @ogizanagi @Nek- @wouterj @carsonbot