update default value for framework.ide #18114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
reviewed
Mar 22, 2023
| @@ -266,7 +266,7 @@ reverse proxy. See :doc:`/deployment/proxies`. | |||
| ide | |||
| ~~~ | |||
|
|
|||
| **type**: ``string`` **default**: ``null`` | |||
| **type**: ``string`` **default**: ``%env(default::SYMFONY_IDE)%`` | |||
There was a problem hiding this comment.
I think we should add a .. versionadded:: 6.1 directive before or after note ?
There was a problem hiding this comment.
It is already on line 323 😉
alamirault
approved these changes
Mar 23, 2023
|
Good catch, thanks Jérôme. |
weaverryan
pushed a commit
that referenced
this pull request
Mar 28, 2023
This PR was merged into the 6.2 branch. Discussion ---------- update default value for framework.ide The default value was changed in symfony/symfony#44575 Commits ------- 9636026 update default value for framework.ide
weaverryan
added a commit
that referenced
this pull request
Mar 28, 2023
* 6.2: feature #17513 [Security] Use expression for `#[IsGranted()]` subject (HypeMC) minor #18114 update default value for framework.ide (GromNaN) minor #18018 [Messenger] add `WorkerRateLimitedEvent` (MrYamous) minor #18081 Update events.rst (hbgamra) minor #18091 [Doctrine] replace ManagerRegistry in doctrine associations doc (MrYamous) minor #18029 [HtmlSanitizer] Fix API usage on PHP config files (alexandre-daubois) Move Notifier bridges doc to the code repo README files Add note about custom port configuration being ignored by specific mailer transport DSN [Notifier] Add link to readme bridges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value was changed in symfony/symfony#44575