Skip to content

Update parameter to compile-time prefix #18341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

yesdevnull
Copy link
Contributor

Use the new compile-time only prefix for build parameters.

See symfony/symfony#47680 for the original feature implementation.

@carsonbot carsonbot added this to the 6.3 milestone May 24, 2023
@carsonbot carsonbot changed the title [Performance] Update parameter to compile-time prefix Update parameter to compile-time prefix May 24, 2023
@yesdevnull
Copy link
Contributor Author

Apologies if this should've been tagged with [DependencyInjection] and [HttpKernel], I opted to use the documentation-specific location tag.

@javiereguiluz
Copy link
Member

Dan, thanks for this contribution.

Before merging this, let me ask @nicolas-grekas because I'm not sure if anything will break when applying this to a parameter used by Symfony itself. Thanks!

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javiereguiluz
Copy link
Member

Dan, thanks for fixing this and congrats on your first Symfony Docs contribution 🎉

Thanks also to Nicolas for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants