[Security] use access decision manager to control which token to vote on #20388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9230ea7 to
50a227e
Compare
50a227e to
fc0030a
Compare
|
Christian, thanks for improving this. Also, while merging I added a |
OskarStark
added a commit
that referenced
this pull request
Nov 19, 2024
…Oliver Kossin) This PR was merged into the 5.4 branch. Discussion ---------- [Security] Fix wrong method call of the decision manager `@xabbuh` changed the use of “decision manage” in [PR-20388](#20388) However, the method is described differently in the [interface](https://github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManagerInterface.php#L29). It's not `isGranted` its `decide` Commits ------- 97599f7 Fix isGranted to decide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following symfony/symfony#58754: calling.
Security::isGranted()inside a voter has the drawback that we do not know if the checks performed here act on the same token that we have in our voter as the token inside the token storage might have change or may change in between.