Skip to content

[#2290] Single command apps with arguments #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2013
Merged

[#2290] Single command apps with arguments #2292

merged 1 commit into from
Mar 21, 2013

Conversation

eugene-dounar
Copy link

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #2290

[#2290] Single command apps with arguments
bd7dfbf 
| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #2290
wouterj
wouterj reviewed Mar 10, 2013
View reviewed changes
components/console/single_command_tool.rst
.. note::

If your command accepts one or more arguments, you may also want to override
getDefinition() method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should indent these 2 lines with 4 spaces

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should change getDefinition() to a method link to the API docs as described here: http://symfony.com/doc/current/contributing/documentation/format.html#adding-links

@wouterj
Copy link
Member

wouterj commented Mar 10, 2013

Offtopic: A small GIT tip from me: Create a new branch (git checkout -b YOUR_NEW_BRANCH) for each PR, this avoids conflicts.

weaverryan added a commit that referenced this pull request Mar 21, 2013
@weaverryan
Merge pull request #2292 from eugene-dounar/2.0
c06454d 
[#2290] Single command apps with arguments
@weaverryan weaverryan merged commit c06454d into symfony:2.0 Mar 21, 2013
weaverryan added a commit that referenced this pull request Mar 21, 2013
@weaverryan
[#2292] Making tweaks per @wouterj and changing method name
5ce533a
weaverryan added a commit that referenced this pull request Mar 21, 2013
@weaverryan
[#2292] Expanding section about the single command that shows and exp…
0b7d8f4 
…lains how to override the getDefinition method
@weaverryan
Copy link
Member

Hi Eugene!

I've merged this in and made a few tweaks that @wouterj mentioned. I verified the issue, so it's an excellent fix. To make it even more obvious, I expanded the code example in sha: 0b7d8f4

If you see any tweaks needed, let me know!

Thanks!

@eugene-dounar eugene-dounar deleted the 2.0 branch March 22, 2013 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugene-dounar @wouterj @weaverryan