Skip to content

Added limitations in 'Managing Common Dependencies with Parent Services'... #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2013

Conversation

venu
Copy link
Contributor

@venu venu commented Apr 13, 2013

This PR adds a caution in 'Managing Common Dependencies with Parent Services' page.

Q A
Doc fix? yes (Improvement on existing docs)
New docs? no
Applies to all
Fixed tickets -

Ref: Source code, Issue

Note: In 2.0 branch, commit (Fixing a bad merge conflict) hasn't been applied yet. As this PR was built on top of 2.0 branch, still this contains the conflicts text. I have another PR in which I have applied that commit manually.


.. caution::

``scope``, ``abstract``, ``abstract`` attributes are always taken from the child.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be:

``scope``, ``abstract``, ``tags`` attributes are always taken from the child.

The last element is tags and not abstract (source comment)

weaverryan added a commit that referenced this pull request May 3, 2013
Added limitations in 'Managing Common Dependencies with Parent Services'...
@weaverryan weaverryan merged commit 0757097 into symfony:2.0 May 3, 2013
weaverryan added a commit that referenced this pull request May 3, 2013
@weaverryan
Copy link
Member

This is a great note to have here (and a very nice and clear PR). Great Work!

Thanks!

@venu venu deleted the adding_caution_parentservices branch May 4, 2013 14:55
@venu
Copy link
Contributor Author

venu commented May 4, 2013

Thank you and its my pleasure to contribute to great framework & documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants