Skip to content

[Cookbook] Added some examples of session save handler proxies #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from May 4, 2013
Merged

[Cookbook] Added some examples of session save handler proxies #2562

merged 5 commits into from May 4, 2013

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2013

Q A
Doc fix? no
New docs? yes
Applies to 2.1+
Fixed tickets n/a

----------------------

The session proxy mechanism has a variety of uses, in this
example we'll demonstrate two common uses. Rather than injecting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always avoid a form of 'we' in the documentation

The session proxy mechanism has a variety of uses, this
example demonstrates two common uses. Rather than injecting
the session handler as normal, a handler is injected into the proxy
and regsitered the proxy with the session::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@stof
Copy link
Member

stof commented Apr 27, 2013

This should be in cookbook/session, not in a new cookbook/sessions

@ghost
Copy link
Author

ghost commented Apr 27, 2013

@stof what do you mean? this PR was created when there was no cookbook/session (which only exists in master afaik) or am I misunderstanding something?

@stof
Copy link
Member

stof commented Apr 27, 2013

@Drak What I mean is that you are using a different folder (plural vs singular) so it should be changed

@ghost
Copy link
Author

ghost commented Apr 27, 2013

@stof fixed - thanks!

weaverryan added a commit that referenced this pull request May 4, 2013
[Cookbook] Added some examples of session save handler proxies
@weaverryan weaverryan merged commit 6990711 into symfony:2.1 May 4, 2013
weaverryan added a commit that referenced this pull request May 4, 2013
@weaverryan
Copy link
Member

Hey Drak!

Very nice entry - it's been merged with no real changes. But why did you choose to put it in the cookbook instead of the components doc? The idea thus far has been that the cookbook is for framework-specific docs, and little-by-little (in part led by your session documentation), we've been adding cookbook-like articles to the components area as well. As this has nothing to do with the framework, how do you feel about moving it the components doc?

Thanks!

@ghost
Copy link
Author

ghost commented May 4, 2013

@weaverryan - it just seemed the logical thing to do. If you think it would be better in the component docs. I have no objection if you move it to the component docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants