Skip to content

Document translation dic tags #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jun 7, 2013

Q A
Doc fix? no
New docs? yes
Applies to 2.1+
Fixed tickets #2347

**Purpose**: To register a custom service that extracts messages from a file

.. versionadded:: 2.1
The ability to add message extractors is new to 2.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is new in :)

weaverryan added a commit that referenced this pull request Jun 30, 2013
@weaverryan weaverryan merged commit ed799f8 into symfony:2.1 Jun 30, 2013
@weaverryan
Copy link
Member

Very very nice job on this Wouter! Well-explained and just about the right length :). My changes were very very minor tweaks.

Cheers!

@wouterj
Copy link
Member Author

wouterj commented Jun 30, 2013

Thank you! The best news: issue #2347 is finally fixed (with the help of many different contributors!).

@weaverryan
Copy link
Member

That's great news - that was a big, long issue indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants