[Security] Fix markup #3501
Merged
[Security] Fix markup #3501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tyx
commented
Jan 22, 2014
| Q | A |
|---|---|
| Doc fix? | Yes |
| New docs? | No |
| Applies to | all |
|
👍 |
|
Then you should also change the next headings, including the |
|
@wouterj You're right I fix that |
|
|
||
| .. _security-book-access-control-matching-options: | ||
|
|
||
| (a) Matching Options | ||
| 1. Matching Options | ||
| .................... |
There was a problem hiding this comment.
this line (the tagline) should be as long as the text of the heading (the headline). Thus: you need to remove one dot from this line.
This should also be done on line 872
There was a problem hiding this comment.
Documentation is precise science ;)
I just amended the commit.
|
👍 thank you for your nice improvement and quick fixes! And it's the first time someone new to the symfony docs knew reSt better than we do 😉 |
|
Wow, great job all around everyone. Nice syntax fix, and good job noticing the other headers if would affect. A model PR :). Cheers! |
weaverryan
added a commit
that referenced
this pull request
Feb 3, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Security] Fix markup | Q | A | ------------- | --- | Doc fix? | Yes | New docs? | No | Applies to | all Commits ------- 72179cb [Security] fix markup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.