Update forms.rst #3548
Merged
Update forms.rst #3548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi there, I thought it would be nice to specify that you can set a label to false to disable it. I needed it for a project, couldn't find it in the doc, and had to search through a couple of stackoverflow posts to find the solution.
| @@ -645,7 +645,7 @@ the documentation for each type. | |||
| )) | |||
|
|
|||
| The label for a field can also be set in the template rendering the | |||
| form, see below. | |||
| form, see below. If you don't need a label associated to your input, you can disable it by setting it's value to 'false'. | |||
There was a problem hiding this comment.
and should put false into literals
There was a problem hiding this comment.
lastly, don't forget to wrap lines after the first word that crosses the 72nd character:
form, see below. If you don't need a label associated to your input, you
can disable it by setting it's value to 'false'.not sure what you meant about the wrapping, I applied a soft wrap after "to your input,". Let me know how that looks
| @@ -645,7 +645,7 @@ the documentation for each type. | |||
| )) | |||
|
|
|||
| The label for a field can also be set in the template rendering the | |||
| form, see below. | |||
| form, see below. If you don't need a label associated to your input, you can disable it by setting its value to false. | |||
There was a problem hiding this comment.
you forgot to wrap it after the first word that crosses the 72th character (after input,, add a line break)
And false should be in a literal (double backticks)
|
got that, cheers |
|
thank you! 👍 |
|
Really nice note - thanks for making a PR on this after you figured it out - that's exactly what we love to see! Cheers! |
weaverryan
added a commit
that referenced
this pull request
Feb 16, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Update forms.rst Hi there, I thought it would be nice to specify that you can set a label to false to disable it. I needed it for a project, couldn't find it in the doc, and had to search through a couple of stackoverflow posts to find the solution. Commits ------- fb5f12d Update forms.rst 3116b39 Update forms.rst 95b4d40 Update forms.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I thought it would be nice to specify that you can set a label to false to disable it. I needed it for a project, couldn't find it in the doc, and had to search through a couple of stackoverflow posts to find the solution.