Skip to content

Rewrote Extension & Configuration docs #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/config/definition.rst
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,8 @@ with ``append()``::
This is also useful to help you avoid repeating yourself if you have sections
of the config that are repeated in different places.

.. _component-config-normalization:

Normalization
-------------

Expand Down Expand Up @@ -445,6 +447,8 @@ a second argument::
->fixXmlConfig('child', 'children')
->children()
->arrayNode('children')
// ...
->end()
->end()
;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about moving the semicolon to the line above?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the place is right imo. It helps the reader's brain to start where it left. Things like this make sense imo more than what the standard says, but oh well.


Expand Down
4 changes: 4 additions & 0 deletions contributing/code/standards.rst
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,13 @@ Service Naming Conventions
~~~~~~~~~~~~~~~~~~~~~~~~~~

* A service name contains groups, separated by dots;

* The DI alias of the bundle is the first group (e.g. ``fos_user``);

* Use lowercase letters for service and parameter names;

* A group name uses the underscore notation;

* Each service has a corresponding parameter containing the class name,
following the ``SERVICE NAME.class`` convention.

Expand Down
Loading