Compiled PHP for customized route matching #4343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second parameter of `rtrim()` is a character mask. By checking if `rtrim($pathinfo, '/contact') === ''`, `$pathinfo` could be any URL containing those characters and not only "/contact" which was configured as the route path, for example:
$pathinfo = '/octocat';
var_dump(rtrim($pathinfo, '/contact') === ''); // bool(true)
| @@ -822,7 +822,7 @@ variables that are passed into the expression: | |||
| Behind the scenes, expressions are compiled down to raw PHP. Our example | |||
| would generate the following PHP in the cache directory:: | |||
|
|
|||
| if (rtrim($pathinfo, '/contact') === '' && ( | |||
| if ('/contact' === $pathinfo && ( | |||
There was a problem hiding this comment.
it should be: if (0 === strpos($pathinfo, '/_profiler') (since this example is just copied verbatim from the generated cache file)
|
Fine by me, @wouterj, as long as that erroneous use of |
wouterj
added a commit
that referenced
this pull request
Oct 26, 2014
This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes #4343). Discussion ---------- Compiled PHP for customized route matching The second parameter of `rtrim()` is a character mask. By checking if `rtrim($pathinfo, '/contact') === ''`, `$pathinfo` could be any URL containing those characters and not only "/contact" which was configured as the route path, for example: $pathinfo = '/octocat'; var_dump(rtrim($pathinfo, '/contact') === ''); // bool(true) Commits ------- fb5e820 Compiled PHP for customized route matching
|
I'm sorry, I looked at the wrong code. I've tested the exact routing config of the documentation and it turns out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second parameter of
rtrim()is a character mask. By checking ifrtrim($pathinfo, '/contact') === '',$pathinfocould be any URL containing those characters and not only "/contact" which was configured as the route path, for example: