Completed framework config #5298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c71426a to
876777a
Compare
876777a to
7e45e8f
Compare
wouterj
added a commit
that referenced
this pull request
May 24, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Completed framework config This PR only changes and adds new configuration, without moving all things around. This will things a lot easier to diff and see where things have gone wrong. I'll thouroughly review this PR and merge then. Replaces #4736 | Q | A | --- | --- | Doc fix? | yes | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #4439, #3586 Commits ------- 54e8b0a Let docbot review reference f223643 Apply some of Ryan's suggestions 7e45e8f Completed framework config reference
|
So this one is finally merged. A huge thanks to everyone who took some minutes/hours to review the previous PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only changes and adds new configuration, without moving all things around. This will things a lot easier to diff and see where things have gone wrong. I'll thouroughly review this PR and merge then.
Replaces #4736