Skip to content

[WCM] Document constraint validator alias made optional #5952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 143 commits into from
Closed

[WCM] Document constraint validator alias made optional #5952

wants to merge 143 commits into from

Conversation

Mx-Glitter
Copy link
Contributor

Q A
Doc fix? yes
New docs? no (symfony/symfony#17074)
Applies to 2.8
Fixed tickets

wouterj and others added 30 commits March 1, 2015 16:15
Terminate the `tip` directive with a blank line.
* 2.7:
  Added February changelog
  Minor fixes and added Fabric tool
  Fixed case where definition service is an alias
  Fixed grammar issues
  Improved the text of the links
  Updated the contents of the generic Deployment article
  Fixed semantic error

Conflicts:
	changelog.rst
This PR was merged into the master branch.

Discussion
----------

[Changelog] fix changelog syntax

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 3.0+
| Fixed tickets |

Terminate the `tip` directive with a blank line.

Commits
-------

653ac94 fix changelog syntax
* 2.7: (38 commits)
  Update configuration.rst
  Update configuration.rst
  Readability
  [#4875] Minor language tweaks
  [#4779] Minor tweaks to a huge PR
  [#4724] Minor language tweaks and cross-link to form theming
  [Serializer] Fix CS
  document the validation payload option
  Fixed some of the comments
  [#4793] Very minor tweak that sounds more natural
  [#4732] Tweaking language, clarifying purpose of disabling form and that you can disable CSRF on 1 form
  [#4732] Tweaking language, clarifying purpose of disabling form and that you can disable CSRF on 1 form
  [config][translator] use the new fallbacks option.
  add missing reference options and descriptions
  Linked "logrotate" to its official website
  Minor rewording
  Added a note about log file sizes and the use of logrotate
  Use snake_case for template names
  Fixed minor grammar issues
  Made http cache chapter best-practices-compatible and lots of other fixes
  ...
* 2.7: (103 commits)
  Backporting some stuff from 2.7, that I think must have gotten merged only there by accident
  [#5064] Minor language tweaks
  Fixing bad merge conflict (forgot to save!)
  Remove unnecessary component reference
  Correct RegisterListenersPass namespace
  Fix service id
  Switched the first example to a static constructor method
  added some more components for Tobion as a merger
  Fixed variable name in : Reference -> validation constraints -> count -> basic usage -> PHP
  [#5036] Typo fix (probably mine originally) caught by xabbuh
  reword to serves
  Adding a link to define "lts"
  Better wording
  Minor improvement for symfony-installer with LTS
  Updating for new security service names in 2.6
  [#5033] Tweaking variable name to "match" the service id
  [#5017] Minor language tweaks
  [#5015] Updating the security service name for 2.6 - thanks to Cordoval
  [#5015] Very small tweak
  [#5011] Adding one more fix I missed
  ...
* 2.7:
  Removing micro-optimization note about @template
* 2.7: (47 commits)
  Removed duplicate "long"s
  terminate file with newline
  move title back and move description to separate file as suggested in PR #4892
  move title out of included file as suggested in PR #4892
  Add possible values for widget_type
  [#4842] Making 2 sentences
  changes as suggested by WouterJ in pull request #4842
  Add meaning of yellow icon for number of queries
  Fixing bad link name
  fix typo in event flow diagrams
  Many fixes thanks to stof, WouterJ, xabbuh and dupuchba
  added Jakub as a merger for the DomCrawler component
  Changes thanks to WouterJ and xabbuh
  [#5094] Removing mkdir - it's not needed (thanks xabbuh)
  some tweaks to #4601
  Moving index down to correct section
  [#4989] Language tweaks and making the example simpler
  Remove useless setLocale() call and add code block with locale setter
  Finaly touches on translation locale setting note
  Review note about setting the translator locale in a controller.
  ...
* 2.8:
  [#5098] Minor fix so controller in dumped apache matches _controller route information above
  fix code block order
  Update process.rst
  [Cookbook] Add warning about Composer dev deps on Heroku
  Added a note against using the Apache Router
  Implemented all the changes suggested by reviewers
  Minor rewording
  Reviewed Configuration cookbook articles
  Reviewed Cache cookbook articles
* 2.8:
  Fix broken link in security chapter
  Add version 2.8 to the release roadmap
  bug #5162 Fix misplelled XliffFileLoader class in the Using Domains (Nicola Pietroluongo)
  Fix misplelled XliffFileLoader class in the Using Message Domains example
  Removing a section about Roles that I think has no real use-case
  add missing security advisories
  Fix misplelled XliffFileLoader class in the Using Message Domains example
  Use correct Session namespace
* 2.8:
  Remove horizontal scrollbar
  Fixed typo.
  Minor rewording
  Fixed a minor grammar issue
  Minor rewording
  Fixed some typos
  Improved the explanation about the "secret" configuration parameter
* 2.8:
  Rewrite utf8mb4 cautions, add comment into sample configuration
  Add backticks for code-styling
  Indenting caution block to nest it inside the sidebar
  Revert "Fix example name to avoid breaking collision with standard data-collectors"
  Revert "Add a cautionary note telling users where the "standard" data-collector names can be found."
  Add a cautionary note telling users where the "standard" data-collector names can be found.
  Fix example name to avoid breaking collision with standard data-collectors
  Change MySQL UTF-8 examples to use utf8mb4, which is closer to the standard most people would expect
  [Cookbook] Custom compile steps on Heroku
  Added information about the Symfony Demo application
  Renamed precision option to scale
* 2.8: (25 commits)
  Update doctrine.rst
  Doctrine Custom Mapping
  fixing whitespace
  Update NotBlank to reflect the actual validation
  Updated autoload standard to PSR-4.
  remove unnecessary code
  uppercase "dependency injection"
  use "Symfony Framework" instead of "Symfony framework"
  use "Form component" instead of "form framework"
  use "full-stack" instead of "full stack"
  unify exception usages
  unify event subscriber usages
  use "console command" instead of "Console Command"
  unify EventDispatcher/event dispatcher usages
  use boolean instead of Boolean
  use "object-oriented" instead of "object oriented"
  "web debug toolbar" instead of "Web Debug Toolbar"
  use "stylesheet" instead of "Stylesheet"
  unify "Symfony Standard Edition" usages
  consistency, replace "save-handler" with "save handler"
  ...
* 2.8: (67 commits)
  Update data_collector.rst
  Updated types articles
  Improve invalid user provider exception message
  Check user provider type
  Use configured user provider instead of injection
  Reviewed form type options includes
  Update authentication.rst
  Update authentication.rst
  Remove Serial Comma
  Update validation.rst
  Improve Choice Validation Constraint Example
  Clarify `query_builder` closure return type
  Remove indentations for all-whitespace lines.
  Fix incorrect instructions regarding linking to the "full panel", improve roll-over data example.
  Flesh out twig-template for custom data-collector
  Simply moving new section down a little lower - I believe some of the other options are a bit more common (totally subjective)
  describe the allow_extra_fields form option
  another fix!
  Fixing things thanks to Wouter
  Tweaks to the new using commands in a controller article
  ...
* 2.8: (21 commits)
  Adding one more note about why we're in config.yml
  [#5302] Re-reading sections after moving them, and tweaking some things that did not make sense anymore
  Update doctrine.rst
  Place DQL in front of QueryBuilder
  Slight re-wording of new paragraph with the goal of being as short as possible
  Fix formatting error
  Created a new section for rotating log files and explained the max_files configuration option
  Fixes after review
  [VarDumper] Add doc for assertDump* assertions
  Changed comment from # to //
  Applied comments
  [BestPractices] restructured text format for the installation instructions template
  Better illustrate what the "user mistake" is.
  Fix typo
  Added new recipe on upgrading a major version
  Fix little title case mistake
  Created 'upgrade' cookbook section
  Added XML and PHP configuration samples
  Added a note about the rotating_file monolog handler
  Changing back to config.yml and fixing some code block mistakes thanks to Wouter
  ...
@Mx-Glitter Mx-Glitter changed the title [WIP] Document constraint validator alias made optional Document constraint validator alias made optional Dec 5, 2015
…ent (ogizanagi)

This PR was merged into the 3.0 branch.

Discussion
----------

Update 3.0 docs accordingly to min PHP version requirement

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 3.0+
| Fixed tickets | #5947

I'm not sure about the politic regarding the removal of anything mentioning earlier version of PHP for the 3.0 docs ? Should it be reverted ?
Regarding this PR: #5585, it's seems coherent to me to do the same for PHP versions.

Commits
-------

d577848 Update docs accordingly to min PHP version requirement
@wouterj wouterj added the On hold label Dec 5, 2015
@wouterj wouterj changed the title Document constraint validator alias made optional [WCM] Document constraint validator alias made optional Dec 5, 2015
@wouterj
Copy link
Member

wouterj commented Dec 5, 2015

For your information, I added [WCM] to your PR title meaning "Waiting Code Merge", as this PR documents on a feature that hasn't made it in Symfony yet.

xabbuh and others added 16 commits December 9, 2015 09:16
Conflicts:
	book/page_creation.rst
	cookbook/deployment/platformsh.rst
	cookbook/symfony1.rst
Conflicts:
	cookbook/service_container/scopes.rst
* 2.8:
  Minor tweaks
  #5999 fix files names
  Updated the other image too
  Fixed the image
  Minor typo
  Rewords
  Minor changes
  Updated the release process for Symfony 3.x and future releases
  removing php opening tags
Conflicts:
	best_practices/creating-the-project.rst
This PR was merged into the 3.0 branch.

Discussion
----------

Fix #6037

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | >= 3.0
| Fixed tickets | #6037

Removed an outdated caution block and rewrote an outdated paragraph.
Hopefully I've done everything correctly *crosses fingers*

Commits
-------

a7effb8 Fix #6037
Conflicts:
	book/service_container.rst
@Mx-Glitter
Copy link
Contributor Author

Closing in favor of #6055 on master branch

@Mx-Glitter Mx-Glitter closed this Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants