Fix binary directory for demo application #6632
Conversation
| @@ -347,7 +347,7 @@ of the Symfony Installer anywhere in your system: | |||
| c:\projects\> php symfony demo | |||
|
|
|||
| Once downloaded, enter into the ``symfony_demo/`` directory and run the PHP's | |||
| built-in web server executing the ``php bin/console server:run`` command. Access | |||
| built-in web server executing the ``php app/console server:run`` command. Access | |||
| to the ``http://localhost:8000`` URL in your browser to start using the Symfony | |||
| Demo application. | |||
There was a problem hiding this comment.
I suggest to add a comment (http://docutils.sourceforge.net/docs/user/rst/quickref.html#comments) explaining why we use app/console, in order to avoid this regression in the future. What do you think @xabbuh ?
|
Should we wait for symfony/demo#338 or fix it now and wait for Symfony 3.1 to be used ? |
|
As symfony/demo#338 was merged do we still want to make this change? |
|
I agree with @xabbuh. Symfony Demo will use Symfony 3.1 starting from the next version. |
|
If the demo works out of the box with 3.1 in the next version, we can definitely close this :) . IMO we have to keep in mind that demo users don't know Symfony though, it has to be certain that they won't have to change anything :) . |
|
@javiereguiluz do you know when the next release will be released? If it's soon, let's close this :) |
|
@wouterj I want to release it ASAP. I'm just waiting a bit so more people can test it and send PRs (yesterday we received some bugfix PRs) |
|
I suggest that we wait until the end of this week and either merge here or celebrate the new demo release. |
|
The latest demo version is updated, so we can safely close this one. Thanks @BaptisteAmato anyway for trying to fix this! |
Hello,
While trying to install the Symfony Demo application following the documentation on http://symfony.com/doc/master/book/installation.html#installing-the-symfony-demo-application, I had a problem as
php bin/console server:rundoes not work.I understood in #6182 that the demo application uses Symfony 2.8 and therefore uses
php app/consolebut I also noticed the regression of this PR in 68650b8.This PR fixes this.