Added docs mentioning UserInterface in action args #7060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Oct 16, 2016
| @@ -995,14 +995,14 @@ After authentication, the ``User`` object of the current user can be accessed | |||
| via the ``security.token_storage`` service. From inside a controller, this will | |||
| look like:: | |||
There was a problem hiding this comment.
this paragraph needs to be changed
There was a problem hiding this comment.
What do you suggest? It's still correct
There was a problem hiding this comment.
Indeed, sorry. The paragraph is a bit confusing, but correct.
wouterj
requested changes
Oct 16, 2016
| @@ -1012,6 +1012,11 @@ look like:: | |||
| The user will be an object and the class of that object will depend on | |||
| your :ref:`user provider <security-user-providers>`. | |||
|
|
|||
| .. versionadded:: 3.2 | |||
| The functionality to get the user via the method signature was added in 3.2, | |||
There was a problem hiding this comment.
"was introduced in Symfony 3.2. You can still retrieve it by [...]"
|
status: needs work Thanks for the docs PR! |
d68c5d7 to
7849fa2
Compare
wouterj
approved these changes
Nov 9, 2016
|
👍 |
xabbuh
reviewed
Nov 12, 2016
| .. versionadded:: 3.2 | ||
| The functionality to get the user via the method signature was introduced in | ||
| Symfony 3.2. You can still retrieve it by calling ``$this->getUser()`` if you | ||
| extend the :class:`Symfony\\Bundle\\FrameworkBundle\\Controller\\Controller`. |
xabbuh
reviewed
Nov 12, 2016
| { | ||
| // $user is null when not logged-in or anon. | ||
| } | ||
|
|
There was a problem hiding this comment.
this blank line should be removed
wouterj
added a commit
that referenced
this pull request
Nov 19, 2016
This PR was merged into the master branch. Discussion ---------- Added docs mentioning UserInterface in action args Added notes about the `UserInterface` added in symfony/symfony#18510, was waiting for the in-deprecation of the `getUser()` method: symfony/symfony#19452. Commits ------- 7849fa2 Added docs mentioning UserInterface in action args
wouterj
added a commit
that referenced
this pull request
Nov 19, 2016
|
Ah thanks! I completely forgot about the reply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notes about the
UserInterfaceadded in symfony/symfony#18510, was waiting for the in-deprecation of thegetUser()method: symfony/symfony#19452.