Update caching.rst #7064
Update caching.rst #7064
Conversation
…andre GESLIN) This PR was merged into the 3.2-dev branch. Discussion ---------- [ExpressionLanguage] Making cache PSR6 compliant | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | [#7064](symfony/symfony-docs#7064) Adding Cache component compatible ParserCache in ExpressionLanguage component. I hope you will find it useful :) I would like to make tests also Commits ------- a7352ff [ExpressionLanguage] Making cache PSR6 compliant
…andre GESLIN) This PR was merged into the 3.2-dev branch. Discussion ---------- [ExpressionLanguage] Making cache PSR6 compliant | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | [#7064](symfony/symfony-docs#7064) Adding Cache component compatible ParserCache in ExpressionLanguage component. I hope you will find it useful :) I would like to make tests also Commits ------- a7352ff [ExpressionLanguage] Making cache PSR6 compliant
| @@ -39,12 +37,6 @@ in the object using the constructor:: | |||
| $cache = new MyDatabaseParserCache(...); | |||
| $language = new ExpressionLanguage($cache); | |||
There was a problem hiding this comment.
Can we maybe enhance this a bit, to show we're really doing PSR-6 here?
E.g. by showing something like:
use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
use Symfony\Component\Cache\RedisAdapter;
$cache = new RedisAdapter(...);
$language = new ExpressionLanguage($cache);Then, we can add a small "seealso" box pointing to the cache component:
.. seealso::
See the :doc:`/components/cache` documentation for more information about
available cache adapters.There was a problem hiding this comment.
Thank you for your help, I agree, I'll do it as soon as possible :)
|
The feature is now merged, congratz @ReDnAxE! Thanks a lot for submitting a doc PR alongside your code PR. I've suggest some changes. If you have some time, please apply the suggestions if you agree with them. Otherwise, you can just comment and we'll finish this PR so it's merged before the 3.2 stable release. status: needs work |
[ExpressionLanguage] Making cache PSR6 compliant
|
I just applied your recommendations ^^, you think it is enough ? status: needs review |
|
👍 I think it's perfect now. Thanks! |
|
👍 |
This PR was merged into the master branch. Discussion ---------- Update caching.rst Updating doc for this PR Making cache PSR6 compliant : [#19741](symfony/symfony#19741) Commits ------- f03f2f3 Update caching.rst
|
Thanks for documenting the feature you submitted! I've merged this into the docs now and made some very minor changes in 31939d5 Hope to see you back in the future! |
Updating doc for this PR Making cache PSR6 compliant : #19741