Skip to content

missing constraint example from the old readme #7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

CoolGoose
Copy link
Contributor

No description provided.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change.

Even if your example is perfectly correct, when a component doc has several pages, in the first page we usually show just one example of how to use it.

But let's wait to hear more opinions about this.

@xabbuh
Copy link
Member

xabbuh commented Nov 28, 2016

Don't we already have a dedicated section in how to validate arrays? I think we should rather link there instead of duplicating its contents then.

@CoolGoose
Copy link
Contributor Author

@xabbuh somehow I missed this reply, do you want me to close this and put the example on the validate array section ?
I think this is a cleaner and simpler example, especially since this is standalone

@xabbuh
Copy link
Member

xabbuh commented Jan 27, 2017

@CoolGoose Yeah, if we want to make improvements, it should be done here: http://symfony.com/doc/current/validation/raw_values.html

@wouterj
Copy link
Member

wouterj commented Apr 15, 2017

Hi @CoolGoose! I've taken your commit and moved the content you added to the raw values sub-guide in: #7805 Thanks for adding this example back in the docs, I think that makes a lot of sense!

@wouterj wouterj closed this Apr 15, 2017
xabbuh added a commit that referenced this pull request Jul 21, 2017
…(CoolGoose, javiereguiluz, wouterj)

This PR was merged into the 2.7 branch.

Discussion
----------

[Validator] Added array validation example to raw values

This example was removed from the component's README and it has some value imo.

Finishes #7161

Commits
-------

06f67b4 Moved array validation to the Raw values sub-guide
64f5ad9 Fixed some syntax issues
c8b6b45 missing constraint example from the old readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants