Skip to content

Remove docs about service_name:method #9468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

Chris-Bitler
Copy link

@Chris-Bitler Chris-Bitler commented Mar 22, 2018

The 'service_name:method' syntax is deprecated as of 4.1

This fixes #9306.

@greg0ire
Copy link
Contributor

Please format your commit message according to these rules :

  • The commit message subject must be less than 50 characters and tell us what you did.
  • The commit message body should tell us why you did it. It is optional but highly recommended.

@Chris-Bitler Chris-Bitler changed the title Update controller/service.rst and routing.rst to remove 'service_name:method' from the docs as it is deprecated Remove docs about service_name:method Mar 22, 2018
It is deprecated as of 4.1.
Fixes symfony#9306
@javiereguiluz
Copy link
Member

@Chris-Bitler thanks for this ... and congrats on your first Symfony Docs contribution! Your changes are correct, but I'm going to update one of these examples in a separate pull request to simplify more things. Thanks!

@javiereguiluz javiereguiluz merged commit a5a5ad7 into symfony:master Mar 22, 2018
javiereguiluz added a commit that referenced this pull request Mar 22, 2018
This PR was merged into the master branch.

Discussion
----------

Remove docs about service_name:method

The 'service_name:method' syntax is deprecated as of 4.1

This fixes #9306.

Commits
-------

a5a5ad7 Remove docs about service_name:method
@Chris-Bitler
Copy link
Author

@javiereguiluz Thanks. I was hesitant to make any more changes than the issue directly asked for, although as I get more used to contributing I'm sure I'll be able to catch that stuff a bit more. :)

javiereguiluz added a commit that referenced this pull request Mar 23, 2018
…guiluz)

This PR was merged into the master branch.

Discussion
----------

Updated an example about controllers as services

This is a continuation of #9468 to simplify more things!

Commits
-------

d73643a Updated an example about controllers as services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update doc to avoid bundle:controller:action and service:method controller syntax
5 participants