Small grammar update in HttpFoundation #9947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"... let you disable buffering at [the] config level or[by] adding ..."
HeahDude
reviewed
Jun 21, 2018
components/http_foundation.rst
Outdated
| @@ -473,7 +473,7 @@ represented by a PHP callable instead of a string:: | |||
|
|
|||
| Additionally, PHP isn't the only layer that can buffer output. Your web | |||
| server might also buffer based on its configuration. Some servers, such as | |||
| Nginx, let you disable buffering at config level or adding a special HTTP | |||
| Nginx, let you disable buffering at the config level by adding a special HTTP | |||
There was a problem hiding this comment.
The or has some meaning here and should be kept. One can either disable by configuring the nginx config file, OR add the header at the application level using Symfony API.
There was a problem hiding this comment.
Gotcha! I'll change it to "or by". That's the missing word here then.
"... let you disable buffering at [the] config level or [by] adding ..."
|
@mattjanssen thanks for fixing these errors. I love this kind of fixes from native English speakers. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"... let you disable buffering at [the] config level or[by] adding ..."