merged branch WouterJ/patch-2 (PR #441)

fabpot · fabpot · commit bab58f11fd88 · 2012-11-10T09:46:09.000+01:00
This PR was merged into the 2.0 branch. Commits ------- 1264284 Changed assertion to be more specific Discussion ---------- [AcmeDemoBundle] Changed assertion to be more specific Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: - Fixes the following tickets: - Todo: - License of the code: MIT Documentation PR: symfony/symfony-docs@67b257e This was changed a long time ago inside the documentation, but not in the actual demo code. It causes an out of sync documentation/code. This PR will solve this.
diff --git a/src/Acme/DemoBundle/Tests/Controller/DemoControllerTest.php b/src/Acme/DemoBundle/Tests/Controller/DemoControllerTest.php
@@ -12,6 +12,6 @@ public function testIndex()
 
         $crawler = $client->request('GET', '/demo/hello/Fabien');
 
-        $this->assertTrue($crawler->filter('html:contains("Hello Fabien")')->count() > 0);
+        $this->assertGreaterThan(0, $crawler->filter('html:contains("Hello Fabien")')->count());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,6 @@ public function testIndex()`
`12`	`12`
`13`	`13`	`$crawler = $client->request('GET', '/demo/hello/Fabien');`
`14`	`14`
`15`		`- $this->assertTrue($crawler->filter('html:contains("Hello Fabien")')->count() > 0);`
	`15`	`+ $this->assertGreaterThan(0, $crawler->filter('html:contains("Hello Fabien")')->count());`
`16`	`16`	`}`
`17`	`17`	`}`