Skip to content

php 8.1 requirement is inconsitent with text message #287

Closed
@lechbaczynski

Description

@lechbaczynski

in book/reqs.go there is a code:

minv, err := version.NewVersion("8.1.0")
(...)
		if v.FullVersion.GreaterThan(minv) {
			terminal.Printfln("<info>[OK]</> PHP installed version %s (%s)", v.FullVersion, v.PHPPath)
		} else {
			ready = false
			terminal.Printfln("<error>[KO]</> PHP installed; version %s found but we need version 7.2.5+ (%s)", v.FullVersion, v.PHPPath)

As I understand, it checks version, and if not 8.1 or higher, shows message:
version %s found but we need version 7.2.5+

The requirement and message is inconsistent.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions