Skip to content

Expose the CLI version and binary name ... #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2022
Merged

Expose the CLI version and binary name ... #231

merged 1 commit into from
Nov 25, 2022

Conversation

tucksaun
Copy link
Member

@tucksaun tucksaun commented Nov 24, 2022 •
edited
Loading

… when running console, php and composer wrappers

Exposing that info via environment variables will allow a better Symfony Maker experience, see symfony/maker-bundle#1238

$ ./symfony-cli php -r "echo getenv('SYMFONY_CLI_BINARY_NAME').' '.getenv('SYMFONY_CLI_VERSION');"
symfony-cli dev
$

@tucksaun tucksaun force-pushed the expose-cli-version-and-name branch from 32a3d89 to 3e87c30 Compare November 24, 2022 21:59
@tucksaun tucksaun mentioned this pull request Nov 24, 2022
Merged
@tucksaun
Copy link
Member Author

waiting for @weaverryan and @jrushlow feedback before moving to ready

@OskarStark
Copy link

I would be more expressive:

- SYMFONY_CLI_BIN_NAME
+ SYMFONY_CLI_BINARY_NAME

or only SYMFONY_CLI_BINARY ?

Do you have an example of the value?

@tucksaun
Copy link
Member Author

The usual value would be symfony but if someone renames the binary to symfony-cli then it would be symfony-cli

@tucksaun
Expose the CLI version and binary name when running console, php …
b27c38d 
…and `composer` wrappers

Exposing that info via environment variables will allow a better Symfony Maker experience, see symfony/maker-bundle#1238
@tucksaun tucksaun force-pushed the expose-cli-version-and-name branch from 3e87c30 to b27c38d Compare November 24, 2022 22:35
@fabpot
Copy link
Contributor

fabpot commented Nov 25, 2022

Is it still draft? Looks great to me.

@fabpot fabpot marked this pull request as ready for review November 25, 2022 06:31
@tucksaun tucksaun merged commit ebd66b2 into symfony-cli:main Nov 25, 2022
@tucksaun tucksaun deleted the expose-cli-version-and-name branch November 25, 2022 16:06
@maxhelias maxhelias mentioned this pull request Nov 27, 2022
Merged
3 tasks
@jrushlow jrushlow mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tucksaun @OskarStark @fabpot