Additional tests for DateTimeValidator, EmailValidator and UrlValidator

stloyd · stloyd · commit 450ed85aa4e0 · 2011-06-16T11:42:28.000+02:00
diff --git a/tests/Symfony/Tests/Component/Validator/Constraints/DateTimeValidatorTest.php b/tests/Symfony/Tests/Component/Validator/Constraints/DateTimeValidatorTest.php
@@ -33,6 +33,11 @@ public function testEmptyStringIsValid()
         $this->assertTrue($this->validator->isValid('', new DateTime()));
     }
 
+    public function testDateTimeClassIsValid()
+    {
+        $this->assertTrue($this->validator->isValid(new \DateTime(), new DateTime()));
+    }
+
     public function testExpectsStringCompatibleType()
     {
         $this->setExpectedException('Symfony\Component\Validator\Exception\UnexpectedTypeException');
diff --git a/tests/Symfony/Tests/Component/Validator/Constraints/EmailValidatorTest.php b/tests/Symfony/Tests/Component/Validator/Constraints/EmailValidatorTest.php
@@ -48,6 +48,17 @@ public function testValidEmails($email)
         $this->assertTrue($this->validator->isValid($email, new Email()));
     }
 
+    /**
+     * @dataProvider getValidEmails
+     */
+    public function testValidEmailsAndCheckMX($email)
+    {
+        $validator = new EmailValidator();
+        $validator->checkMX = true;
+
+        $this->assertTrue($validator->isValid($email, new Email()));
+    }
+
     public function getValidEmails()
     {
         return array(
diff --git a/tests/Symfony/Tests/Component/Validator/Constraints/UrlValidatorTest.php b/tests/Symfony/Tests/Component/Validator/Constraints/UrlValidatorTest.php
@@ -76,6 +76,8 @@ public function getInvalidUrls()
             array('google.com'),
             array('http:/google.com'),
             array('http://google.com::aa'),
+            array('http://google.foobar'),
+            array('ftp://google.fr'),
         );
     }
 

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,11 @@ public function testEmptyStringIsValid()`
`33`	`33`	`$this->assertTrue($this->validator->isValid('', new DateTime()));`
`34`	`34`	`}`
`35`	`35`
	`36`	`+ public function testDateTimeClassIsValid()`
	`37`	`+ {`
	`38`	`+ $this->assertTrue($this->validator->isValid(new \DateTime(), new DateTime()));`
	`39`	`+ }`
	`40`	`+`
`36`	`41`	`public function testExpectsStringCompatibleType()`
`37`	`42`	`{`
`38`	`43`	`$this->setExpectedException('Symfony\Component\Validator\Exception\UnexpectedTypeException');`
Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,8 @@ public function getInvalidUrls()`
`76`	`76`	`array('google.com'),`
`77`	`77`	`array('http:/google.com'),`
`78`	`78`	`array('http://google.com::aa'),`
	`79`	`+ array('http://google.foobar'),`
	`80`	`+ array('ftp://google.fr'),`
`79`	`81`	`);`
`80`	`82`	`}`
`81`	`83`