Skip to content

Commit 30aaeef

Browse files
Rokesh-KarthikeyanRokesh-Karthikeyan
committed
flut-5960-[feature][flutter]: review changes
1 parent 3f81195 commit 30aaeef

File tree

7 files changed

+23
-40
lines changed

7 files changed

+23
-40
lines changed

‎Flutter/cartesian-charts/callbacks.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -992,10 +992,9 @@ Triggers when the error bar is being rendered. In this `onRenderDetailsUpdate` c
992992

993993
Used to create the renderer for custom series.This is applicable only when the custom series is defined in the sample and for built-in series types, it is not applicable.
994994

995-
Renderer created in this will hold the series state and this should be created for each series. [onCreateRenderer]() callback function should return the renderer class and should not return null.
995+
Renderer created in this will hold the series state and this should be created for each series.[onCreateRenderer]() callback function should return the renderer class and should not return null.
996996

997-
Series state will be created only once per series and will not be created
998-
again when we update the series.
997+
Series state will be created only once per series and will not be created again when we update the series.
999998

1000999
Defaults to `null`.
10011000

@@ -1016,17 +1015,17 @@ Defaults to `null`.
10161015
}
10171016
class CustomColumnSeriesRenderer extends ColumnSeriesRenderer {
10181017
// custom implementation here...
1019-
@override
1020-
ChartSegment createSegment() {
1021-
return _ColumnCustomPainter();
1018+
@override
1019+
ChartSegment createSegment() {
1020+
return _ColumnCustomPainter();
10221021
}
10231022
}
10241023

10251024
class _CustomColumnSeriesRenderer extends ColumnSeriesRenderer {
10261025
_CustomColumnSeriesRenderer(this.series);
10271026

10281027
final ColumnSeries<dynamic, dynamic> series;
1029-
@override
1028+
@override
10301029
ChartSegment createSegment() {
10311030
return _ColumnCustomPainter(series);
10321031
}

‎Flutter/circular-charts/callbacks.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -409,17 +409,11 @@ the data points and legend. For further reference on this callback, Check the [`
409409

410410
## onCreateRenderer
411411

412-
Used to create the renderer for custom series.
412+
Used to create the renderer for custom series.This is applicable only when the custom series is defined in the sample and for built-in series types, it is not applicable.
413413

414-
This is applicable only when the custom series is defined in the sample
415-
and for built-in series types, it is not applicable.
414+
Renderer created in this will hold the series state and this should be created for each series. [onCreateRenderer]() callback function should return the renderer class and should not return null.
416415

417-
Renderer created in this will hold the series state and
418-
this should be created for each series. [onCreateRenderer] callback
419-
function should return the renderer class and should not return null.
420-
421-
Series state will be created only once per series and will not be created
422-
again when we update the series.
416+
Series state will be created only once per series and will not be created again when we update the series.
423417

424418
Defaults to `null`.
425419

‎Flutter/circular-charts/datalabel.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -432,8 +432,7 @@ If the user didn’t provide text color to the data label, then by default, the
432432

433433
Action on data labels when it’s overflowing from its region area.The overflowing data label rendering behavior can be changed based on this. If `overflowMode` property is set to `OverflowMode.none` then the `labelIntersectAction` takes the priority, else `overflowMode` takes the priority.
434434

435-
_Note:_ This is applicable for pie, doughnut, pyramid, and funnel series
436-
types alone.
435+
_Note:_ This is applicable for pie, doughnut, pyramid, and funnel series types alone.
437436

438437
Defaults to `OverflowMode.none`.
439438

@@ -453,5 +452,5 @@ Defaults to `OverflowMode.none`.
453452
)
454453
);
455454
}
456-
455+
{% endhighlight %}
457456
![dataLabel_overflow](images/datalabel/circular_overflow.jpg)

‎Flutter/funnel-chart/callbacks.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -312,10 +312,9 @@ Triggers when long press on the series point. The [`onPointLongPress`](https://p
312312

313313
Used to create the renderer for custom series. This is applicable only when the custom series is defined in the sample and for built-in series types, it is not applicable.
314314

315-
Renderer created in this will hold the series state and this should be created for each series. [onCreateRenderer] callback function should return the renderer class and should not return null.
315+
Renderer created in this will hold the series state and this should be created for each series. [onCreateRenderer]() callback function should return the renderer class and should not return null.
316316

317-
Series state will be created only once per series and will not be created
318-
again when we update the series.
317+
Series state will be created only once per series and will not be created again when we update the series.
319318

320319
Defaults to `null`.
321320

‎Flutter/funnel-chart/datalabel.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,10 @@ If the user didn’t provide text color to the data label, then by default, the
169169

170170
Action on data labels when it’s overflowing from its region area.
171171

172-
The overflowing data label rendering behavior can be changed based on this. If `overflowMode` property is set to `OverflowMode.none` then the `labelIntersectAction` takes the priority, else
173-
`overflowMode` takes the priority.
172+
The overflowing data label rendering behavior can be changed based on this. If [overflowMode]() property is set to `OverflowMode.none` then the `labelIntersectAction` takes the priority, else
173+
[overflowMode]() takes the priority.
174174

175-
_Note:_ This is applicable for pie, doughnut, pyramid, and funnel series
176-
types alone.
175+
_Note:_ This is applicable for pie, doughnut, pyramid, and funnel series types alone.
177176

178177
Defaults to `OverflowMode.none`.
179178

@@ -191,5 +190,6 @@ Defaults to `OverflowMode.none`.
191190
),
192191
);
193192
}
193+
{% endhighlight %}
194194

195195
![label_overflow](images/datalabel/funnel_overflow.jpg)

‎Flutter/pyramid-chart/callbacks.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -313,17 +313,11 @@ Triggers when long press on the series point. The [`onPointLongPress`](https://p
313313

314314
## onCreateRenderer
315315

316-
Used to create the renderer for custom series.
316+
Used to create the renderer for custom series. This is applicable only when the custom series is defined in the sample and for built-in series types, it is not applicable.
317317

318-
This is applicable only when the custom series is defined in the sample
319-
and for built-in series types, it is not applicable.
318+
Renderer created in this will hold the series state and this should be created for each series. [onCreateRenderer]() callback function should return the renderer class and should not return null.
320319

321-
Renderer created in this will hold the series state and
322-
this should be created for each series. [onCreateRenderer] callback
323-
function should return the renderer class and should not return null.
324-
325-
Series state will be created only once per series and will not be created
326-
again when we update the series.
320+
Series state will be created only once per series and will not be created again when we update the series.
327321

328322
Defaults to `null`.
329323

‎Flutter/pyramid-chart/datalabel.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -252,11 +252,9 @@ If the user didn’t provide text color to the data label, then by default, the
252252

253253
Action on data labels when it’s overflowing from its region area.
254254

255-
The overflowing data label rendering behavior can be changed based on this. If `overflowMode` property is set to `OverflowMode.none` then the `labelIntersectAction` takes the priority, else
256-
`overflowMode` takes the priority.
255+
The overflowing data label rendering behavior can be changed based on this. If [overflowMode]() property is set to `OverflowMode.none` then the `labelIntersectAction` takes the priority, else [overflowMode]() takes the priority.
257256

258-
_Note:_ This is applicable for pie, doughnut, pyramid, and funnel series
259-
types alone.
257+
_Note:_ This is applicable for pie, doughnut, pyramid, and funnel series types alone.
260258

261259
Defaults to `OverflowMode.none`.
262260

@@ -274,5 +272,5 @@ Defaults to `OverflowMode.none`.
274272
)
275273
);
276274
}
277-
275+
{% endhighlight %}
278276
![label_overflow](images/datalabel/pyramid_overflow.jpg)

0 commit comments

Comments
 (0)