Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer context #10

Closed
rlnt opened this issue Feb 1, 2022 · 5 comments
Closed

Explorer context #10

rlnt opened this issue Feb 1, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@rlnt
Copy link

rlnt commented Feb 1, 2022

It would be nice if the Open in new window action would also be existing in the explorer context.
Currently, you can only open files in new windows if you opened them.

This would be handy because you could just right-click any file from your explorer tree to open it in a new window.
There is another extension that does this. I had to combine yours with it to have both options.

I also requested the tab context action on their repository but it wasn't updated since 2020 so I try it here.
https://github.com/onatm/open-in-new-window

@takkaO
Copy link
Owner

takkaO commented Feb 1, 2022

Thank you for using this extension ! 😉

At the moment, I am reluctant to take this issue.
There are two reasons.
The first is that it seems to be able to achieve the required functionality by combining it with onatm's extension.
The second reason is that onatm's extension has no bugs or security issues (or so it seems).

If Mr. onatm's extension has some problems or security holes and they are not addressed, I am willing to add the function to OpenWindowTabContext.

@rlnt
Copy link
Author

rlnt commented Feb 1, 2022

The reason I am requesting this is to remove one extension. VSCode gets more and more bloated because of different extensions that only add one feature. Installing additional extensions which only add a compatibility feature to an already existing feature just seems unnecessary.
I don't think this suggestion is out of the scope of your extension since it's a nice QoL feature and would really save some time.
Adding the functionality of your extension was also considered here: onatm/open-in-new-window#3

@takkaO
Copy link
Owner

takkaO commented Feb 2, 2022

VSCode gets more and more bloated because of different extensions that only add one feature.

I understand your feelings to some degree.

I will try to develop the features suggested in this issue.
However, we will carefully consider whether or not to merge them in the end.

@takkaO takkaO added the enhancement New feature or request label Feb 2, 2022
@takkaO
Copy link
Owner

takkaO commented Feb 17, 2022

I have implemented this feature on a trial basis since version 1.7.0.
Please enable the feature in your settings and give us feedback on this feature.

@rlnt
Copy link
Author

rlnt commented Feb 18, 2022

Works very well. I was able to instantly uninstall the other extension. Thanks a lot!

@takkaO takkaO closed this as completed Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants