Skip to content

Commit 04fae2a

Browse files
ptarjanbrandjon
authored andcommitted
Fix extra dependencies (bazel-contrib#211)
Remove duplicate dependencies to avoid errors in deps attribute, and regenerate the .par files.
1 parent d0191f0 commit 04fae2a

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

rules_python/whl.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,8 @@ def dependencies(self, extra=None):
8282
the names of requirements from the metadata.json
8383
"""
8484
# TODO(mattmoor): Is there a schema to follow for this?
85+
dependency_set = set()
86+
8587
run_requires = self.metadata().get('run_requires', [])
8688
for requirement in run_requires:
8789
if requirement.get('extra') != extra:
@@ -96,7 +98,9 @@ def dependencies(self, extra=None):
9698
for entry in requires:
9799
# Strip off any trailing versioning data.
98100
parts = re.split('[ ><=()]', entry)
99-
yield parts[0]
101+
dependency_set.add(parts[0])
102+
103+
return dependency_set
100104

101105
def extras(self):
102106
return self.metadata().get('extras', [])

tools/piptool.par

69 Bytes
Binary file not shown.

tools/whltool.par

138 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)