Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounty: UI Improvement: Use dialog instead of window.prompt for Add Token button #42

Open
temptemp3 opened this issue Nov 16, 2023 · 8 comments · May be fixed by #73
Open

Bounty: UI Improvement: Use dialog instead of window.prompt for Add Token button #42

temptemp3 opened this issue Nov 16, 2023 · 8 comments · May be fixed by #73
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@temptemp3
Copy link
Owner

temptemp3 commented Nov 16, 2023

Currently, ARC200 app uses window.prompt to accept token id to add token. There is an add asa/vsa and add arc200 button, 2 buttons.
Combine add token buttons into single button. Have user enter "Token Id." Check if token id is asset id of arc200 token and use else check for asset id else fail. In case of standard asset, optin if not in wallet yet before adding.
Bounty: 10k VIA
Please leave proposal in comments along with VOI Address to deliver rewards upon accepted submission. Account of address provided must have balance.

@temptemp3 temptemp3 added this to ARC200 Jun 27, 2023
@temptemp3 temptemp3 converted this from a draft issue Nov 16, 2023
@temptemp3 temptemp3 added good first issue Good for newcomers enhancement New feature or request labels Nov 16, 2023
@piyushjaiswal1610
Copy link

Hi Nicholas,

Thank you for providing clear guidance on the changes you'd like to see in the ARC200 app. I've carefully considered your requirements, and I propose the following approach to address the issue:

- Combine Add Token Buttons:

Create a single button labeled "Add Token."
Upon clicking, prompt the user to enter the "Token Id."
Token Id Validation:

- Check if the entered Token Id is the asset id of the ARC200 token.

If it is, proceed with the addition of the token.
If not, check if it is a standard asset id.
If it is a standard asset, prompt the user to opt-in if not already in the wallet before adding.
Implementation Details:

- Modify the UI to have a single button.

Utilize conditional statements to handle the different scenarios based on the entered Token Id.
Provide clear error messages for cases of invalid Token Id or failed operations.
Testing:

- Ensure thorough testing of the new functionality.

Test with both ARC200 and standard assets to cover all use cases.

Note: I am not sure of what's VOI address

Best regards,
Piyush Jaiswal

@temptemp3
Copy link
Owner Author

Hi Nicholas,

Thank you for providing clear guidance on the changes you'd like to see in the ARC200 app. I've carefully considered your requirements, and I propose the following approach to address the issue:

- Combine Add Token Buttons:

Create a single button labeled "Add Token." Upon clicking, prompt the user to enter the "Token Id." Token Id Validation:

- Check if the entered Token Id is the asset id of the ARC200 token.

If it is, proceed with the addition of the token. If not, check if it is a standard asset id. If it is a standard asset, prompt the user to opt-in if not already in the wallet before adding. Implementation Details:

- Modify the UI to have a single button.

Utilize conditional statements to handle the different scenarios based on the entered Token Id. Provide clear error messages for cases of invalid Token Id or failed operations. Testing:

- Ensure thorough testing of the new functionality.

Test with both ARC200 and standard assets to cover all use cases.

Note: I am not sure of what's VOI address

Best regards, Piyush Jaiswal

Sound good. Please submit fork the repo and submit a PR. Thx!

Btw, here is a video tutorial of how to create a VOI account. There you should have your VOI address.

https://www.youtube.com/watch?v=0qZu4nTKF5E

@temptemp3
Copy link
Owner Author

Let me know once you have VOI account. Thx!

@temptemp3 temptemp3 added help wanted Extra attention is needed bounty labels Nov 16, 2023
@lovish2223
Copy link

Interested @temptemp3

@farolanf
Copy link
Contributor

Is anyone currently working on this? If not, I have a PR ready.

@temptemp3
Copy link
Owner Author

temptemp3 commented Dec 21, 2023 via email

@farolanf farolanf linked a pull request Dec 21, 2023 that will close this issue
@farolanf
Copy link
Contributor

How do I add VIA asset to my Voi account on https://www.a-wallet.net? I tried adding 6779767 from

but got error 'Asset not found'.

Additionally, how can I cash out VIA tokens later if there's no Voi Mainnet?

@temptemp3 temptemp3 changed the title Bounty: UI Improvement: Use dialog instead of window.prompt for Add Token button (10k VIA) Bounty: UI Improvement: Use dialog instead of window.prompt for Add Token button Jan 9, 2024
@temptemp3
Copy link
Owner Author

@farolanf you can continue working on this if you. complete it I will still consider the bounty reward. VIA is an arc 200. You should be able to add it from the tokens page.

@temptemp3 temptemp3 removed the bounty label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

4 participants