Merge pull request coder#90 from coder/code-server-extensions

stirby · web-flow · commit b6ec1d85a750 · 2023-10-13T14:49:33.000-05:00
code-server: fix multiple-extension installation
diff --git a/code-server/README.md b/code-server/README.md
@@ -63,6 +63,18 @@ module "settings" {
 }
 ```
 
+### Install multiple extensions
+
+Just run code-server in the background, don't fetch it from GitHub:
+
+```hcl
+module "settings" {
+    source = "https://registry.coder.com/modules/code-server"
+    agent_id = coder_agent.example.id
+    extensions = [ "dracula-theme.theme-dracula", "ms-azuretools.vscode-docker" ]
+}
+```
+
 ### Offline Mode
 
 Just run code-server in the background, don't fetch it from GitHub:
diff --git a/code-server/run.sh b/code-server/run.sh
@@ -25,7 +25,8 @@ printf "🥳 code-server has been installed in ${INSTALL_PREFIX}\n\n"
 CODE_SERVER="${INSTALL_PREFIX}/bin/code-server"
 
 # Install each extension...
-for extension in "$${EXTENSIONS[@]}"; do
+IFS=',' read -r -a EXTENSIONLIST <<< "$${EXTENSIONS}"
+for extension in "$${EXTENSIONLIST[@]}"; do
   if [ -z "$extension" ]; then
     continue
   fi
@@ -46,4 +47,4 @@ fi
 
 echo "👷 Running code-server in the background..."
 echo "Check logs at ${LOG_PATH}!"
-$CODE_SERVER --auth none --port ${PORT} >${LOG_PATH} 2>&1 &
+$CODE_SERVER --auth none --port ${PORT} >${LOG_PATH} 2>&1 &
