Skip to content

Commit 5a1210b

Browse files
committed
Skip read lines from empty file
Signed-off-by: yugo-horie <u5.horie@gmail.com>
1 parent f613750 commit 5a1210b

File tree

3 files changed

+14
-0
lines changed

3 files changed

+14
-0
lines changed

internal/reader/lines.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,13 @@ func (l *Lines) Extract() ([]string, error) {
3535
if err != nil {
3636
return nil, err
3737
}
38+
stat, err := f.Stat()
39+
if err != nil {
40+
return nil, err
41+
}
42+
if stat.Size() == 0 {
43+
return []string{}, nil
44+
}
3845
defer func() {
3946
_ = f.Close()
4047
}()

internal/reader/lines_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,13 @@ func TestReadLinesFromFile(t *testing.T) {
103103
expected: "Morbi vitae nulla in dui lobortis consectetur. Integer nec tempus felis. Ut quis suscipit risus. Donec lobortis consequat nunc, in efficitur mi maximus ac. Sed id felis posuere, aliquam purus eget, faucibus augue.",
104104
wantError: false,
105105
},
106+
{
107+
name: "extract lines from file",
108+
fileName: "testdata/empty.txt",
109+
lineNumber: 0,
110+
expected: "",
111+
wantError: false,
112+
},
106113
{
107114
name: "extract lines from file",
108115
fileName: "testdata/noop.txt",

internal/reader/testdata/empty.txt

Whitespace-only changes.

0 commit comments

Comments
 (0)