Skip to content

Commit 90ccb84

Browse files
Add missing Resource.Mode to plugin-sdk (#493)
* add fix for #492. Signed-off-by: Sergey Yakovlev <syakovlev@dalet.com> * add additional comparisons to test for #492. Signed-off-by: Sergey Yakovlev <syakovlev@dalet.com> Co-authored-by: Sergey Yakovlev <syakovlev@dalet.com>
1 parent 7ca2750 commit 90ccb84

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

internal/terraform/resource.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ func (rr resources) convert() []*terraformsdk.Resource {
9191
Name: r.Name,
9292
ProviderName: r.ProviderName,
9393
ProviderSource: r.ProviderSource,
94+
Mode: r.Mode,
9495
Version: fmt.Sprintf("%v", r.Version.Raw()),
9596
Position: terraformsdk.Position{
9697
Filename: r.Position.Filename,

internal/terraform/resource_test.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,24 @@ func TestResourceSpec(t *testing.T) {
3131
}
3232
assert.Equal("tls_private_key.baz", resource.Spec())
3333
}
34+
func TestPluginSdkConversion(t *testing.T) {
35+
assert := assert.New(t)
36+
resource := Resource{
37+
Type: "private_key",
38+
Name: "baz",
39+
ProviderName: "tls",
40+
ProviderSource: "hashicorp/tls",
41+
Mode: "managed",
42+
Version: types.String("latest"),
43+
}
44+
sdkResource := resources{&resource}.convert()[0]
45+
assert.Equal(resource.Type, sdkResource.Type)
46+
assert.Equal(resource.Name, sdkResource.Name)
47+
assert.Equal(resource.ProviderName, sdkResource.ProviderName)
48+
assert.Equal(resource.ProviderSource, sdkResource.ProviderSource)
49+
assert.Equal(resource.Mode, sdkResource.Mode)
50+
assert.Equal(resource.Version, types.String(sdkResource.Version))
51+
}
3452

3553
func TestResourceMode(t *testing.T) {
3654
tests := map[string]struct {

0 commit comments

Comments
 (0)