Fix: remove null_data_sources #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Díaz <agustin.ramiro.diaz@gmail.com>
|
Is there something I can do to help this PR get reviewed? |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Remove stale label |
|
/gcbrun |
bharathkkb
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Sorry for the delay and thanks for the PR @AgustinRamiroDiaz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #182
Changes proposed
Remove usages of
null_data_sourceand address the impact accordingly, preserving the configuration values and thedepends_onThis should not make any modification in behavior
Testing done
I've run applies that created, deleted and updated the resources using my fork module which points to this branch
All plans were successful and the resources were correctly applied in GCP